Closed Bug 1441855 Opened 7 years ago Closed 7 years ago

--chrome-nav-buttons-background and --chrome-nav-buttons-hover-background are defined but never referenced

Categories

(Firefox :: Theme, defect, P3)

Product:
Firefox
Component:
Theme
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: jaws, Assigned: mkohler)

References

Details

Attachments

(1 file)

Bug 1441855 - remove unused --chrome-nav-buttons-background and --chrome-nav-buttons-hover-background definitions r=jaws
(deleted), text/x-phabricator-request
jaws
: review+
Details 
This is a regression from bug 1366555.
Flags: needinfo?(me)
Summary: --chrome-nav-buttons-background is defined but never referenced → --chrome-nav-buttons-background and --chrome-nav-buttons-hover-background are defined but never referenced
Good catch, will remove those definitions.
Assignee: nobody → me
Status: NEW → ASSIGNED
Flags: needinfo?(me)
Bug 1441882 added a test that catches these types of errors. When fixing this, the entry for this bug will need to be removed from the whitelist in browser_parsable_css.js.
Priority: -- → P3
Removes unused --chrome-nav-buttons-background and --chrome-nav-buttons-hover-background definitions
Comment on attachment 8966337 [details]
Bug 1441855 - remove unused --chrome-nav-buttons-background and --chrome-nav-buttons-hover-background definitions r=jaws

Jared Wein [:jaws] (please needinfo? me) has approved the revision.

https://phabricator.services.mozilla.com/D890
Attachment #8966337 - Flags: review+
Keywords: checkin-needed
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a012de95bb20
remove unused --chrome-nav-buttons-background and --chrome-nav-buttons-hover-background definitions r=jaws
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a012de95bb20
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: