Closed
Bug 1442080
Opened 7 years ago
Closed 7 years ago
IsOrHasAncestorWithDisplayNone could be faster for Servo.
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(1 file)
Followup to bug 1432490.
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 2•7 years ago
|
||
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8954992 [details]
Bug 1442080: Make IsOrHasAncestorWithDisplayNone faster in the Servo case.
https://reviewboard.mozilla.org/r/224176/#review230184
So elements can have servo data attached only during traversal, and we would never traverse into `display: none` tree so those elements should never have servo data with them.
Attachment #8954992 -
Flags: review?(xidorn+moz) → review+
|
|
Assignee | |
Comment 4•7 years ago
|
||
(In reply to Xidorn Quan [:xidorn] UTC+10 from comment #3)
> Comment on attachment 8954992 [details]
> Bug 1442080: Make IsOrHasAncestorWithDisplayNone faster in the Servo case.
>
> https://reviewboard.mozilla.org/r/224176/#review230184
>
> So elements can have servo data attached only during traversal, and we would
> never traverse into `display: none` tree so those elements should never have
> servo data with them.
Right.
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9c264168781f
Make IsOrHasAncestorWithDisplayNone faster in the Servo case. r=xidorn
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•