Closed
Bug 1442851
Opened 7 years ago
Closed 7 years ago
[taskcluster] Use comm-central revision in routes
Categories
(Thunderbird :: Build Config, defect)
Thunderbird
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 60.0
People
(Reporter: darktrojan, Assigned: darktrojan)
References
Details
Attachments
(1 file)
When a revision is a part of the route, the m-c revision is used when the c-c one would be more useful.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
I pushed this to try earlier, and nothing exploded so I assume all is well.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d18dc3ee70b58a73fa663c62942ae6dc07110f77
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8955751 [details]
Bug 1442851 - Use comm-central revision in routes;
https://reviewboard.mozilla.org/r/224830/#review231450
Thanks for your contribution! This looks pretty much exactly like what I was envisioning when we talked the other day. Sorry for the delay in reviewing. I've added Dustin as a reviewer, since he is an owner of this code.
After having looked at this, another option occured to me, but I think we should go with the current patch, at least for now. The constants could move to [taskcluster/ci/config.yml](https://searchfox.org/mozilla-central/source/taskcluster/ci/config.yml) (which has a [thunderbird counterpart](https://searchfox.org/comm-central/source/taskcluster/ci/config.yml)). They could then just point to the different params. That would allow indexing comm-central bracnhes by both the c-c and m-c branches. That being said, this solves the issue at hand, and keeping the indexing consistent is probably a bigger win, at least for the moment.
::: taskcluster/taskgraph/transforms/task.py:668
(Diff revision 1)
> 'comm-aurora': 'comm_head_rev',
> 'try-comm-central': 'comm_head_rev',
> }
>
> +
> +def get_treeherder_rev(config):
I'm not sure that `treeherder_rev` is the most descriptive name, now that the use has expanded. I think `project_rev` (or maybe `branch_rev`) would be a better name. And the global constant should be changed to match the too.
Attachment #8955751 -
Flags: review?(mozilla) → review+
Updated•7 years ago
|
Attachment #8955751 -
Flags: review?(dustin)
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8955751 [details]
Bug 1442851 - Use comm-central revision in routes;
https://reviewboard.mozilla.org/r/224830/#review231806
::: taskcluster/taskgraph/transforms/task.py:668
(Diff revision 1)
> 'comm-aurora': 'comm_head_rev',
> 'try-comm-central': 'comm_head_rev',
> }
>
> +
> +def get_treeherder_rev(config):
Haha, I had the same thought. Given the use of BRANCH_REV_PARAM, I think `branch_rev` makes a lot of sense.
Attachment #8955751 -
Flags: review?(dustin) → review-
Comment hidden (mozreview-request) |
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8955751 [details]
Bug 1442851 - Use comm-central revision in routes;
https://reviewboard.mozilla.org/r/224830/#review231890
Attachment #8955751 -
Flags: review?(dustin) → review+
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/integration/autoland/rev/cc4a9008f2ce
Use comm-central revision in routes; r=dustin,tomprince
Comment 8•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 60.0
You need to log in
before you can comment on or make changes to this bug.
Description
•