Closed
Bug 1444106
Opened 7 years ago
Closed 7 years ago
Add test for rapid addition and removal of items in the storage inspector
Categories
(DevTools :: Storage Inspector, enhancement, P2)
DevTools
Storage Inspector
Tracking
(firefox61 fixed)
RESOLVED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: miker, Assigned: miker)
References
Details
Attachments
(1 file)
The UI works in the same way for all items so we only need to test on one type e.g. localStorage:
```
localStorage.setItem("test","true");
localStorage.removeItem("test");
```
Historically this has left an item in the table but due to the fixes in bug 1443461 this is no longer the case so we need a test.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8957539 [details]
Bug 1444106 - Add test for rapid addition and removal of items in the storage inspector
https://reviewboard.mozilla.org/r/226418/#review232604
Thanks for the test Mike!
Could you use async/await instead of generators and yield?
(Note that I'll be on PTO next week, so you would find another reviewer if you have other patches ;))
::: devtools/client/storage/test/browser_storage_localstorage_rapid_add_remove.js:30
(Diff revision 1)
> + yield addRemove("test9");
> + yield addRemove("test10");
> + yield addRemove("test11");
> + yield addRemove("test12");
> + yield addRemove("test13");
> + yield addRemove("test14");
You can use a `for` loop here.
::: devtools/client/storage/test/browser_storage_localstorage_rapid_add_remove.js:38
(Diff revision 1)
> +});
> +
> +function* addRemove(name) {
> + yield ContentTask.spawn(gBrowser.selectedBrowser, {}, () => {
> + content.localStorage.setItem("name", "true");
> + content.localStorage.removeItem("name");
You may want to pass `name` instead of `"name"` here. Otherwise you don't use `name` argument.
Attachment #8957539 -
Flags: review?(poirot.alex) → review+
Assignee | ||
Updated•7 years ago
|
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/42ab3dc3d93d
Add test for rapid addition and removal of items in the storage inspector r=ochameau
Comment 5•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•