We need to remove CPOWs from devtools/server/tests/browser/browser_storage_updates.js and simplify the test.

Comment on attachment 8959215 [details] Bug 1446037 - Remove CPOWs from browser_storage_dynamic_windows.js and simplify the test https://reviewboard.mozilla.org/r/228100/#review233972 Thanks for this! :) Looks reasonable to me. ::: devtools/server/tests/browser/browser_storage_dynamic_windows.js:8 (Diff revision 1) > http://creativecommons.org/publicdomain/zero/1.0/ */ > > "use strict"; > > -const {StorageFront} = require("devtools/shared/fronts/storage"); > -Services.scriptloader.loadSubScript("chrome://mochitests/content/browser/devtools/server/tests/browser/storage-helpers.js", this); > +const { StorageFront } = require("devtools/shared/fronts/storage"); > +Services.scriptloader.loadSubScript("chrome://mochitests/content/browser/devtools/" + I would suggest something like this[1] which keeps the path all on one line. This makes it easier to find when searching. Not a requirement, though. [1]: https://searchfox.org/mozilla-central/rev/8976abf9cab8eb4661665cc86bd355cd08238011/devtools/client/inspector/test/head.js#13 ::: devtools/server/tests/browser/browser_storage_dynamic_windows.js:70 (Diff revision 1) > - info("Everything to be received is received."); > - endTestReloaded(); > - } > + } > - }; > +}; > > - let endTestReloaded = () => { > +// afterIframeAdded references the items deleted when an iframe containing Nit: wrong name here

Pushed by mratcliffe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/84badebad54b Remove CPOWs from browser_storage_dynamic_windows.js and simplify the test r=jryans