Closed
Bug 1447641
Opened 7 years ago
Closed 7 years ago
Clean up DevTools l10n config
Categories
(Core :: Internationalization: Localization, enhancement, P1)
Core
Internationalization: Localization
Tracking
()
VERIFIED
FIXED
People
(Reporter: Pike, Assigned: Pike)
References
Details
Attachments
(2 files)
(deleted),
text/x-review-board-request
|
flod
:
review+
|
Details |
(deleted),
patch
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1446222 +++
The DevTools landing in bug 1446222 changed the l10n.toml files in ways which make cross-channel unhappy.
Notably, we need the config on central to be valid for all branches.
We'll also need to port this to comm-central, https://hg.mozilla.org/comm-central/rev/008a5e87d53b copied the problem over.
Comment 1•7 years ago
|
||
I imagine you meant Bug 1444926? Updating the dependency.
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8960932 [details]
Bug 1447641, follow up to 1444926 to fix l10n.toml for cross-channel,
https://reviewboard.mozilla.org/r/229678/#review235442
Nit on the commit message
::: commit-message-f4ddf:1
(Diff revision 1)
> +Bug 1447641, follow up to 1446222 to fix l10n.toml for cross-channel, r?flod
Need to update the bug number: "follow up to bug 1444926"
Attachment #8960932 -
Flags: review?(francesco.lodolo) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Severity: normal → major
Priority: P3 → P1
Pushed by axel@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/7b55d395bb63
follow up to 1444926 to fix l10n.toml for cross-channel, r=flod, a=Aryx
Assignee | ||
Comment 6•7 years ago
|
||
Jorg, do you want me to land the corresponding fix in c-c, too, or are you going to do that?
Flags: needinfo?(jorgk)
Comment 7•7 years ago
|
||
I'll do it. It would be nice if you could attach a patch :-)
Flags: needinfo?(jorgk)
Assignee | ||
Comment 8•7 years ago
|
||
This is the patch, also see that I fixed a nit about '/' being in the one l10n path, which breaks stuff in subtle ways. That has been broken for long, never got around to fix it, now I do.
Comment 9•7 years ago
|
||
Thanks, I'll get this landed with the next batch soon.
Comment 10•7 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/2b766c459949
follow-up to bug 1444926 to fix l10n.toml for cross-channel (C-C part). r=flod
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 11•7 years ago
|
||
Both fixes worked out and the cross-channel automation works again.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•