Closed
Bug 1448734
Opened 7 years ago
Closed 7 years ago
Stop exposing Components in content XBL sopes
Categories
(Core :: XBL, enhancement)
Core
XBL
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
(deleted),
patch
|
kmag
:
review+
|
Details | Diff | Splinter Review |
None of the bindings we apply to content normally use Components. We should just stop exposing it in content XBL scopes, on the way to making Components only available to system-principal stuff.
Assignee | ||
Comment 1•7 years ago
|
||
Kris, let me know if you would rather we just wait until Bobby gets back to get this reviewed. But I don't think he'd object. ;)
Attachment #8962228 -
Flags: review?(kmaglione+bmo)
Comment 2•7 years ago
|
||
Comment on attachment 8962228 [details] [diff] [review]
Stop exposing Components in content XBL scopes
Review of attachment 8962228 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/xpconnect/tests/chrome/test_bug795275.xul
@@ +65,5 @@
> getWin('frame2').touchInterfaces();
> getWin('frame4').touchComponents();
> getWin('frame4').touchInterfaces();
> + // This should warn twice (actually throw exceptions, because Components
> + // won't be defined).
I don't think this is right. It definitely emits the warning, which means we're accessing the content window's Components getter. Which it is defined. (Also, it doesn't seem to throw.)
Attachment #8962228 -
Flags: review?(kmaglione+bmo) → review+
Assignee | ||
Comment 3•7 years ago
|
||
> I don't think this is right.
Right you are. I'll fix the comments.
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f9c9c64510c
Stop exposing Components in content XBL scopes. r=kmag
Comment 5•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•