Closed Bug 1456093 Opened 7 years ago Closed 5 years ago

Investigate alternatives to disabling smooth scrolling in the tab bar during session restore

Categories

(Toolkit :: XUL Widgets, task, P5)

task

Tracking

()

RESOLVED INACTIVE
Tracking Status
firefox61 --- affected

People

(Reporter: Paolo, Unassigned)

References

Details

Bug 483403 added a workaround that disabled smooth scrolling during session restore. Dão, do you remember why this was introduced, was it just to make the selected tab immediately visible? Is this code still needed, and if so do you know if this can be done in other ways? Or Mike? I'm looking at the arrowscollbox binding and, apart from test code, this seems to be the only place where we change the smooth scrolling mode at runtime.
Flags: needinfo?(mdeboer)
Flags: needinfo?(dao+bmo)
(In reply to :Paolo Amadini from comment #0) > Bug 483403 added a workaround that disabled smooth scrolling during session > restore. > > Dão, do you remember why this was introduced, was it just to make the > selected tab immediately visible? Is this code still needed, and if so do > you know if this can be done in other ways? Or Mike? It's still needed. When restoring a window, we don't want to animate scrolling to the selected tab as this is both distracting and expensive. > I'm looking at the arrowscollbox binding and, apart from test code, this > seems to be the only place where we change the smooth scrolling mode at > runtime. Why is this a problem?
Flags: needinfo?(dao+bmo)
Flags: needinfo?(mdeboer) → needinfo?(paolo.mozmail)
There are several XBL bindings that control scrolling, mainly for historical reasons, and we are looking into flattening the inheritance in preparation for a conversion to Custom Elements. I'm now looking into which common features are required. The current approach here of exposing a smoothScroll property may still work, but another possibility is to expose a method parameter to scroll instantly, or even use the underlying CSS frame scrolling methods. Moving the bug to XUL Widgets since this is more of an investigation driven by the work we're doing there, rather than something we have to fix in Session Restore.
Blocks: war-on-xbl
Component: Session Restore → XUL Widgets
Flags: needinfo?(paolo.mozmail)
Priority: -- → P5
Product: Firefox → Toolkit
Type: enhancement → task

Paolo, is this something you think we should still investigate now that related bindings (like arrowscrollbox) have been converted to Custom Elements, or should this bug be closed?

No longer blocks: war-on-xbl
Flags: needinfo?(paolo.mozmail)

Hm, I'd say this bug is potentially valid in that it would be nice if we didn't have to keep this state in the Custom Element, but it is probably not a bug worth addressing or tracking on its own, if there are no other reasons to touch this code.

Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(paolo.mozmail)
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.