Closed
Bug 1456296
Opened 7 years ago
Closed 7 years ago
Move IdentifierName parsing into a separate function from TSS::getTokenInternal
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: Waldo, Assigned: Waldo)
Details
Attachments
(1 file)
|
(deleted),
patch
|
arai
:
review+
|
Details | Diff | Splinter Review |
Simplifies some control flow by eliminating some gotos, gets rid of some locals in getTokenInternal.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8970373 -
Flags: review?(arai.unmht)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8970373 [details] [diff] [review]
Patch
Review of attachment 8970373 [details] [diff] [review]:
-----------------------------------------------------------------
Nice simplification :)
Attachment #8970373 -
Flags: review?(arai.unmht) → review+
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3010f9088dc7
Move IdentifierName parsing into a separate function from TSS::getTokenInternal to simplify some control flow. r=arai
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•