Closed Bug 1457511 Opened 7 years ago Closed 7 years ago

Unknown telemetry events for rollback action

Categories

(Firefox :: Normandy Client, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 61
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox59 --- unaffected
firefox60 --- unaffected
firefox61 + verified
firefox62 --- verified

People

(Reporter: aflorinescu, Assigned: mythmon)

References

Details

Attachments

(1 file, 1 obsolete file)

[Prerequisites:] 1. Set the app.normandy.dev_mode preference to true to run recipes immediately on startup. 2. Set the app.normandy.logging.level preference to 0 to enable more logging. 3. Set the security.content.signature.root_hash preference to DB:74:CE:58:E4:F9:D0:9E:E0:42:36:BE:6C:C5:C4:F6:6A:E7:74:7D:C0:21:42:7A:03:BC:2F:57:0C:8B:9B:90. 4. Set the preference value for app.normandy.api_url set to https://normandy.stage.mozaws.net/api/v1 [Steps:] 1. Open Control Center: https://normandy-admin.stage.mozaws.net/control-new 2. Create a rollout type recipe. 3. Run Fx with prerequisites. 4. Open Control Center and create a rollback recipe on the same preference/preferences as step 2. 5. Rerun the same Fx profile as str 3. [Actual Result:] [Show/hide message details.] Unknown event: ["normandy", "unenrollFailure", "preference_rollout"] TelemetryEvents.jsm:61 sendEvent resource://normandy/lib/TelemetryEvents.jsm:61:5 _run resource://normandy/actions/PreferenceRollbackAction.jsm:27:7 InterpretGeneratorResume self-hosted:1264:8 next self-hosted:1219:9
Assignee: nobody → mcooper
Something seems to have gone wrong with these patches... did you intend to submit only 1 cset?
Flags: needinfo?(mcooper)
Comment on attachment 8971737 [details] Bug 1457511 - Check that Normandy telemetry events match schema https://reviewboard.mozilla.org/r/240500/#review246476 r=me on this with the second cset squashed into it and the nit below fixed. ::: toolkit/components/normandy/test/browser/head.js:350 (Diff revision 1) > + stub.callsFake(checkFunction); > + try { > + await testFunction(...args, stub); Nit: maybe call checkFunction something like `checkEventMatchesSchema` or something else more descriptive. Right now you have 'testFunction' and 'checkFunction' and they do very different things.
Attachment #8971737 - Flags: review+
Attachment #8971738 - Flags: review?(gijskruitbosch+bugs)
Attachment #8971738 - Attachment is obsolete: true
Apologies for the duplicate cset. I think I must have `hg commit`ed when I meant to `hg amend`. I've squashed the two together, and made the requested changes. I triggered autoland for this now.
Flags: needinfo?(mcooper)
Pushed by mcooper@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2a88d31a05cd Check that Normandy telemetry events match schema r=Gijs
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Flags: qe-verify+
I have verified it on latest normandy staging env: - on Fx 61.0b6 and 62.0a1 (2018-05-20) rollback works as expected and the correct data is shown in telemetry
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: