Netmonitor uses Reps to represent raw objects instead of grips. Therefore it should pass the noGrip:true parameter. Otherwise it can fail e.g. display "Invalid object" when there is an object with a "type":"string" property. Example from bug 1377668 comment 24: https://content.googleapis.com/discovery/v1/apis/storage/v1/rest?fields=kind%2Cname%2Cversion%2CrootUrl%2CservicePath%2Cresources%2Cparameters%2Cmethods%2CbatchPath%2Cid&pp=0 The result looks like https://bug1377668.bmoattachments.org/attachment.cgi?id=8971803 Searching with https://searchfox.org/mozilla-central/search?q=%5CbRep%5C(&case=false&regexp=true&path=netmonitor, it seems the codes that should be fixed are https://searchfox.org/mozilla-central/rev/68fdb6cf4f40bea1a1f6c07531ebf58fb8ab060b/devtools/client/netmonitor/src/components/HeadersPanel.js#150 https://searchfox.org/mozilla-central/rev/68fdb6cf4f40bea1a1f6c07531ebf58fb8ab060b/devtools/client/netmonitor/src/components/PropertiesView.js#159

Thanks for the report Oriol! Honza

Comment on attachment 8974056 [details] Bug 1457701 - Use Reps with noGrip:true in netmonitor; https://reviewboard.mozilla.org/r/242376/#review248244 Code analysis found 1 defect in this patch: - 1 defect found by mozlint You can run this analysis locally with: - `./mach lint path/to/file` (JS/Python) If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx ::: devtools/client/netmonitor/test/browser_net_json-nogrip.js:15 (Diff revision 1) > +add_task(async function() { > + let { tab, monitor } = await initNetMonitor(JSON_BASIC_URL + "?name=nogrip"); > + info("Starting test... "); > + > + let { document, store, windowRequire } = monitor.panelWin; > + let { L10N } = windowRequire("devtools/client/netmonitor/src/utils/l10n"); Error: 'l10n' is assigned a value but never used. [eslint: no-unused-vars]

With https://github.com/devtools-html/debugger.html/pull/6211, the existing browser_net_json-long.js test would have already failed without noGrip:true. So it would be nice if someone reviewed it.

Comment on attachment 8974056 [details] Bug 1457701 - Use Reps with noGrip:true in netmonitor; https://reviewboard.mozilla.org/r/242376/#review248254 Looks good! Thanks for adding the test as well. :)

Thanks for quick review, try looks good. https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9dcf613fc73620e66d51f3060a0e329b9a164bc (the ES error is fixed) (In reply to Oriol Brufau [:Oriol] from comment #5) > With https://github.com/devtools-html/debugger.html/pull/6211, the existing > browser_net_json-long.js test would have already failed without noGrip:true. > So it would be nice if someone reviewed it. I'll talk to Nicolas about it, thanks for the link. Not a blocker for this bug. Honza

Pushed by jodvarko@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c68911c91fee Use Reps with noGrip:true in netmonitor; r=jryans