Closed
Bug 1458490
Opened 7 years ago
Closed 7 years ago
don't get confused if 'revert' is part of the commit message
Categories
(Tree Management :: Bugherder, enhancement)
Tree Management
Bugherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: aryx, Assigned: aryx)
Details
Attachments
(1 file)
If 'revert' is part of the commit message, bugherder treats it as a backout unless it's a partial backout https://github.com/mozilla/bugherder/blob/0d29c5de3e600f30170e98cade5afcd29dd6e2b9/bugherder/js/PushData.js#L157
This causes changesets to be wrongly classified as backouts, see https://bugherder.mozilla.org/?cset=6276ec7ebbf33e3484997b189f20fc1511534187&tree=mozilla-central
Should "revert" be ignored if it's anywhere but the start (after the bug number) in the commit message or also if directly after the bug number because these reference a different bug which doesn't get reopened. See Andrei's push in https://bugherder.mozilla.org/?cset=6eeb97ca94f40189d5aa552da9e0b0b11bfa0441&tree=mozilla-central as example.
Flags: needinfo?(ryanvm)
Comment 1•7 years ago
|
||
Sounds worth a try. Just make sure the SV folks are on the lookout for any false positives so we can weigh the risk/reward better.
Flags: needinfo?(ryanvm)
Assignee | ||
Comment 2•7 years ago
|
||
Test e.g. with
https://bugherder.mozilla.org/?cset=6eeb97ca94f40189d5aa552da9e0b0b11bfa0441&tree=mozilla-central
and
https://bugherder.mozilla.org/?cset=6276ec7ebbf33e3484997b189f20fc1511534187&tree=mozilla-central
Attachment #8972827 -
Flags: review?(ryanvm)
Updated•7 years ago
|
Attachment #8972827 -
Flags: review?(ryanvm) → review+
Assignee | ||
Comment 3•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•