Applying the same rationale as bug 1341742, it doesn't really make sense for the user to give a one-time permission to store persistent data (i.e. not checking the checkbox actually means denying the request). We should probably transform the persistent-storage dialog to look like the web notification dialog, where we have the following layout: [ Not Now |\/] [ Allow ] | Never allow | --------------- To keep the current behavior we could also switch the two deny options: [ Never allow |\/] [ Allow ] | Not now | ------------------ Or just get rid of the "Not now" version (which amounts to just removing the checkbox): [ Never allow ] [ Allow ] Maybe the last one is cleanest, the middle one doesn't really make sense to me. The user can revert this decision in the control center, page info and the site data manager, so I don't think the "permanent" part is a big problem here.

This makes sense to me, but I'm not sure I understand how the persistent storage permission is surfaced in the site data manager. I'm assuming by site data manager, you mean https://support.mozilla.org/en-US/kb/storage, but the only permission-related thing is the Exceptions' dialog exposure of the cookie permission. Aside: Do we have a glossary/similar reference that links to the SuMo pages like the above and https://support.mozilla.org/en-US/kb/control-center-site-privacy-and-security-firefox ?

(In reply to Andrew Sutherland [:asuth] from comment #1) > This makes sense to me, but I'm not sure I understand how the persistent > storage permission is surfaced in the site data manager. I'm assuming by > site data manager, you mean https://support.mozilla.org/en-US/kb/storage, > but the only permission-related thing is the Exceptions' dialog exposure of > the cookie permission. Persistent storage will have "(Persistent)" in parentheses after the storage size in the "Storage" column. It's not very common at this point. And clearing the storage will always clear the persistent-storage permission, both ALLOW and BLOCK (we're kind of assuming the user wants a fresh start on that domain, it's hard to get this perfectly right without overloading the user with choices). > Aside: Do we have a glossary/similar reference that links to the SuMo pages > like the above and > https://support.mozilla.org/en-US/kb/control-center-site-privacy-and- > security-firefox ? I don't :( There's bug 1441804 which has more information on support articles.

Remove the checkbox from the persistent storage notification.

Pushed by prathikshaprasadsuman@gmail.com: https://hg.mozilla.org/integration/autoland/rev/d52479cf19f9 Remove the checkbox from the persistent storage notification. r=johannh