Closed
Bug 1463611
Opened 7 years ago
Closed 7 years ago
Remove remaining uses of promiseWebExtensionStartup hack
Categories
(Toolkit :: Add-ons Manager, enhancement)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: kmag, Assigned: kmag)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
This hack is largely unnecessary now that the add-on manager knows about the lifecycle of async bootstrap methods.
|
Assignee | |
Comment 1•7 years ago
|
||
I'm ignoring the remaining embedded WebExtension tests, because those need to die by fire, and I do not want to touch them.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 6•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8979802 [details]
Bug 1463611: Part 1 - Wait for all extensions to finish starting up in promiseStartupManager.
https://reviewboard.mozilla.org/r/245954/#review252396
Attachment #8979802 -
Flags: review?(aswan) → review+
|
|
||
Comment 7•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8979803 [details]
Bug 1463611: Part 2 - Wait for extension startup before resolving install() promise.
https://reviewboard.mozilla.org/r/245956/#review252400
Attachment #8979803 -
Flags: review?(aswan) → review+
|
|
||
Comment 8•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8979805 [details]
Bug 1463611: Part 3 - Fix nonsense. ?aswan
https://reviewboard.mozilla.org/r/245958/#review252402
I assume the commit message was a typo and you actually wanted a review of this...
::: toolkit/mozapps/extensions/test/xpcshell/test_webextension.js:397
(Diff revision 2)
> });
>
> - await AddonManager.installTemporaryAddon(webext);
> - let addon = await promiseAddonByID(ID);
> -
> // temporary add-on is installed and started
nit: this isn't temporary any more
Attachment #8979805 -
Flags: review+
|
|
||
Comment 9•7 years ago
|
||
There are still a number of uses promiseWebExtensionStartup() not covered by the patches here...
|
|
Assignee | |
Comment 10•7 years ago
|
||
(In reply to Andrew Swan [:aswan] from comment #9)
> There are still a number of uses promiseWebExtensionStartup() not covered by
> the patches here...
See comment 1.
|
||
Comment 11•7 years ago
|
||
Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c1f7ebe48f23
Part 1 - Wait for all extensions to finish starting up in promiseStartupManager. r=aswan
https://hg.mozilla.org/integration/mozilla-inbound/rev/f546f7584212
Part 2 - Wait for extension startup before resolving install() promise. r=aswan
https://hg.mozilla.org/integration/mozilla-inbound/rev/0461688b6a09
Part 3 - Fix nonsense. r=aswan
|
|
Assignee | |
Comment 12•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c1f7ebe48f2331e3a22db062136b1e6acbb99938
Bug 1463611: Part 1 - Wait for all extensions to finish starting up in promiseStartupManager. r=aswan
https://hg.mozilla.org/integration/mozilla-inbound/rev/f546f7584212113a9c484b56d6a41bd935fc2089
Bug 1463611: Part 2 - Wait for extension startup before resolving install() promise. r=aswan
https://hg.mozilla.org/integration/mozilla-inbound/rev/0461688b6a091d3088f32206a449d9add7142948
Bug 1463611: Part 3 - Fix nonsense. r=aswan
|
||
Comment 13•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c1f7ebe48f23
https://hg.mozilla.org/mozilla-central/rev/f546f7584212
https://hg.mozilla.org/mozilla-central/rev/0461688b6a09
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
|
||
Updated•6 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•