Closed
Bug 1467837
Opened 7 years ago
Closed 7 years ago
adjust some code for test-coverage gpu/chunks and minor cleanup in per test code
Categories
(Testing :: General, enhancement)
Testing
General
Tracking
(firefox62 fixed)
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: jmaher, Assigned: jmaher)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
gbrown
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8984510 [details] [diff] [review]
some minor fixes for per-test and TCg
Review of attachment 8984510 [details] [diff] [review]:
-----------------------------------------------------------------
Just need to sort out the max-run-time issue, otherwise looks okay.
::: taskcluster/ci/test/misc.yml
@@ +93,5 @@
> instance-size:
> by-test-platform:
> android.*: xlarge
> default: default
> + max-run-time: 5400
TV max-run-time was increased in bug 1431125 from 5400 to 10800. Has that caused problems? Do we have a solution in place to avoid timeouts during verification of long-running tests?
Attachment #8984510 -
Flags: review?(gbrown)
Comment 3•7 years ago
|
||
Comment on attachment 8984510 [details] [diff] [review]
some minor fixes for per-test and TCg
Review of attachment 8984510 [details] [diff] [review]:
-----------------------------------------------------------------
As discussed on irc, r+ with max-run-time unmodified.
Attachment #8984510 -
Flags: review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/37faedd44291
adjust some code for test-coverage gpu/chunks and minor cleanup in per test code. r=gbrown
Comment 5•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•