Closed Bug 1472522 Opened 6 years ago Closed 6 years ago

Show image, video, audio, text attachments inline

Categories

(bugzilla.mozilla.org :: User Interface, enhancement)

Product:
bugzilla.mozilla.org
Component:
User Interface
Version:
Production
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: kohei, Assigned: kohei)

References

Details

(Keywords: bmo-ux)

Attachments

(2 files)

GitHub Pull Request
(deleted), text/x-github-pull-request
Details
Test-Picture.jpg
(deleted), image/jpeg
Details
Let’s display attached images and text files on the thread along with the associated comment, like other apps. Regarding the performance: * Hopefully image thumbnails could be generated to reduce bandwidth, but given that it requires backend and infra changes, we could only show small original images inline for now because we know the size. * With the Intersection Observer API, attachments can now be displayed once the page is scrolled down and each comment becomes visible in the browser’s content area. API: https://developer.mozilla.org/en-US/docs/Web/API/Intersection_Observer_API WIP: https://github.com/kyoshino/bmo/compare/inline-attachments Demo: https://twitter.com/BugzillaUX/status/1012614594878103552
Markdown support should go first to avoid any conflict or regression.
Depends on: bmo-markdown-initial-release
Status: ASSIGNED → NEW
Summary: Show image/text attachments inline → Show image/text attachments and Firefox Screenshots inline
Blocks: bmo-markdown
Blocks: 1518323
No longer blocks: bmo-markdown

Firefox Screenshots won’t be supported as the upload option will be removed. Users can still copy a screenshot and paste it directly to Bugzilla’s attachment uploader, which is pretty convenient.

Summary: Show image/text attachments and Firefox Screenshots inline → Show image/text attachments inline

The Intersection Observer API support is finally coming to Safari so we don’t have to compromise the UX of WebKit Bugzilla users and Safari users in general 😉 I’ll restart working on this soon.

Will do this soonish.

Status: NEW → ASSIGNED
Attached file GitHub Pull Request (deleted) —
Summary: Show image/text attachments inline → Show image, video, audio, text attachments inline

Merged to master.

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Depends on: 1535190
Depends on: 1535723
Depends on: 1541231
Regressions: 1542101
Depends on: 1542882
No longer regressions: 1542101

Great feature, but how does it work? I followed the Markdown styling! that is now supported and inserted the following line in this comment:

![Image of Yaktocat](https://octodex.github.com/images/yaktocat.png)

I have expected to see the image of yaktocat in the preview right above this line. But it is not shown there. Perhaps it will be shown after saving the changes?

No, I cannot see the image of yaktocat in the comment, even after saving my comment.

This only shows attachments = files uploaded to Bugzilla inline, as the bug summary says. See Bug 1555771 for example. The Markdown image syntax is a different story, and it’s not (won’t be) supported.

Attached image Test-Picture.jpg (deleted) —

Ok, understood. I am just trying out, wher a picture, that was uploaded as an attachment, will appear in the timeline. Does is show up on the top, or within the list of the comments?

Ok, great, the pictures is diplayed properly together with the comment. That is nearly the same effect as creating it with the Markdown image syntax.

Component: User Interface: Modal → User Interface
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: