The new frame can be seen here: https://perfht.ml/2LjKBLz

Comment on attachment 8994875 [details] Bug 1478393 - Add AutoGeckoProfilerEntry to parsing of script in BytecodeCompiler::compileScript https://reviewboard.mozilla.org/r/259408/#review267596 ::: js/src/frontend/BytecodeCompiler.cpp:335 (Diff revision 1) > return nullptr; > > for (;;) { > ParseNode* pn; > + { > + AutoGeckoProfilerEntry pseudoFrame(cx, "BytecodeCompiler::CompileScript::parse"); I know we have some existing examples that do this, but I would really really prefer the label here to *not* look like a C++ function name. "script parsing", maybe? ::: js/src/frontend/BytecodeCompiler.cpp:342 (Diff revision 1) > - pn = parser->evalBody(sc->asEvalContext()); > + pn = parser->evalBody(sc->asEvalContext()); > - else > + else > - pn = parser->globalBody(sc->asGlobalContext()); > + pn = parser->globalBody(sc->asGlobalContext()); > + } > > // Successfully parsed. Emit the script. As long as you're here, can you add another pseudo frame "script emit"? You shouldn't need another scope, you can just let it go from here to the end of the for (;;) body.

Thanks for the feedback sfink! Edited the string and added a new frame for "script emit". Could you look at it again?

Comment on attachment 8994875 [details] Bug 1478393 - Add AutoGeckoProfilerEntry to parsing of script in BytecodeCompiler::compileScript https://reviewboard.mozilla.org/r/259408/#review267774

Comment on attachment 8996650 [details] Bug 1478393 - Add AutoGeckoProfilerEntry to emitting of script in BytecodeCompiler::compileScript https://reviewboard.mozilla.org/r/260744/#review267778 Perfect, thanks!

Pushed by canaltinova@gmail.com: https://hg.mozilla.org/integration/autoland/rev/c36fc94df388 Add AutoGeckoProfilerEntry to parsing of script in BytecodeCompiler::compileScript r=sfink https://hg.mozilla.org/integration/autoland/rev/75ef4a9cbc00 Add AutoGeckoProfilerEntry to emitting of script in BytecodeCompiler::compileScript r=sfink

https://hg.mozilla.org/mozilla-central/rev/c36fc94df388 https://hg.mozilla.org/mozilla-central/rev/75ef4a9cbc00