Closed Bug 148093 Opened 23 years ago Closed 22 years ago

Editmilestones shows 'xyzzy' as the product bug count

Categories

(Bugzilla :: Administration, task)

2.17
task
Not set
trivial

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: jouni, Assigned: jouni)

Details

Attachments

(1 file, 2 obsolete files)

Go to editmilestones.cgi without a parameter, and you'll see a bug table with bug counts written as 'xyzzy'. A ridiculously old minor bug, but I'll attach a patch anyway.
Attached patch Patch (obsolete) (deleted) — Splinter Review
Takes a bug count instead :-)
Status: NEW → ASSIGNED
Keywords: patch, review
Target Milestone: --- → Bugzilla 2.18
Comment on attachment 85573 [details] [diff] [review] Patch How does this affect bug 153445? Won't this cause the same problem for editMilestones as we have for editproducts?
Probably yes, but I don't think that's an issue. When 153445 gets fixed, it's easy to fix this as well. Another approach is to totally remove bug counts (the xyzzy column) from this page. I really don't care that much, but I think Asa's perf problem in 153445 is practically bmo-specific since no other installation has that many bugs. If a reasonable number of other installations can benefit from querying the bug counts, we should do it. What do you want to do with this?
I don't know - the fix for the other bug is likly to involve removing the feature, ast least until we use a db with row level locking.
Attached patch v2: kill (obsolete) (deleted) — Splinter Review
Ok, let's just remove the bug counts then. By the way, MySQL sucks. :-)
Attachment #85573 - Attachment is obsolete: true
Attached patch v3: Removed bitrot (deleted) — Splinter Review
Here's a version without the bitrot.
Attachment #90927 - Attachment is obsolete: true
Comment on attachment 111076 [details] [diff] [review] v3: Removed bitrot You were the only one interested in this months ago when I made the last patch. Now pay the price and r=. ;-)
Attachment #111076 - Flags: review?(bbaetz)
Comment on attachment 111076 [details] [diff] [review] v3: Removed bitrot r=bbaetz. Wehn we support non-sucky dbs we could turn this back on conditionally
Attachment #111076 - Flags: review?(bbaetz) → review+
Flags: approval?
Flags: approval? → approval+
Checking in editmilestones.cgi; /cvsroot/mozilla/webtools/bugzilla/editmilestones.cgi,v <-- editmilestones.cgi new revision: 1.13; previous revision: 1.12 done
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: