Closed
Bug 1485373
Opened 6 years ago
Closed 6 years ago
Use client.mainRoot.getFront to fetch all global actors
Categories
(DevTools :: Framework, enhancement, P2)
DevTools
Framework
Tracking
(firefox64 fixed)
RESOLVED
FIXED
Firefox 64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: ochameau, Assigned: yulia)
References
Details
(Whiteboard: dt-fission)
Attachments
(1 file)
There is still a couple of places where we instanciate the fronts manually:
* ActorRegistryFront:
https://searchfox.org/mozilla-central/search?q=ActorRegistryFront&case=false®exp=false&path=devtools
This is only used by tests, but inspector tests actually depends on this still
* AddonsFront:
https://searchfox.org/mozilla-central/search?q=AddonsFr&case=false®exp=false&path=
This one is really only used by tests. about:debugging should be using it, but isn't.
* PerfFront:
https://searchfox.org/mozilla-central/source/devtools/client/performance-new/panel.js#34
The new performance panel uses a global actor because gecko profiler runs in the parent process. So that the perf panel isn't really specific to a tab but connect to an actor with a global vison over all Firefox.
Nevertheless, we can refactor this callsite.
Assignee | ||
Comment 1•6 years ago
|
||
PerfFront is taken care of in https://bugzilla.mozilla.org/show_bug.cgi?id=1493680 and in https://bugzilla.mozilla.org/show_bug.cgi?id=1487428
Assignee | ||
Comment 2•6 years ago
|
||
Reporter | ||
Comment 3•6 years ago
|
||
Comment on attachment 9011823 [details]
Bug 1485373 - Use client.mainRoot.getFront to fetch all global actors; r=ochameau
Alexandre Poirot [:ochameau] has approved the revision.
Attachment #9011823 -
Flags: review+
Pushed by ystartsev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7a3062ce9107
Use client.mainRoot.getFront to fetch all global actors; r=ochameau
Comment 5•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Updated•6 years ago
|
Assignee: nobody → ystartsev
Reporter | ||
Updated•6 years ago
|
Whiteboard: dt-fission
You need to log in
before you can comment on or make changes to this bug.
Description
•