Closed Bug 1486968 Opened 6 years ago Closed 5 years ago

Remove nsPrintJob::mOldPrtPreview

Categories

(Core :: Printing: Setup, task, P3)

Product:
Core
Component:
Printing: Setup
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla73
Tracking Flags:
Tracking Status
firefox73 --- disabled
firefox74 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

(Whiteboard: [print2020_v74])

Attachments

(1 file)

Bug 1486968. Remove nsPrintJob::mOldPrtPreview. r=bobowen
(deleted), text/x-phabricator-request
Details
The purpose of nsPrintJob::mOldPrtPreview is unclear and the code inconsistent in its use. We should try to remove this member. I tried that in bug 1425641 previously, but it caused browser chrome test toolkit/components/printing/tests/browser_page_change_print_original.js to fail.
Priority: -- → P3

It turns out that the crash wasn't a result of failing to keep mOldPrtPreview around to hold onto for something. Rather, the issue was that we need to clear mPrtPreview (a side affect of mOldPrtPreview = std::move(mPrtPreview)) so that we didn't use that stale object.

Attachment #9114177 - Attachment description: Bug 1486968 - Remove nsPrintJob::mOldPrtPreview. r=bobowen → Bug 1486968. Remove nsPrintJob::mOldPrtPreview. r=bobowen
Pushed by jwatt@jwatt.org: https://hg.mozilla.org/integration/autoland/rev/60e9aedf5428 Remove nsPrintJob::mOldPrtPreview. r=bobowen
Blocks: 1587459
Type: enhancement → task

https://hg.mozilla.org/mozilla-central/rev/60e9aedf5428

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox73: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
Whiteboard: [print_v74]
Whiteboard: [print_v74] → [print2020_v74]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: