Closed Bug 1494605 Opened 6 years ago Closed 6 years ago

Use target.getFront to instantiate PerformanceFront

Categories

(DevTools :: Performance Tools (Profiler/Timeline), enhancement, P3)

Product:
DevTools
Component:
Performance Tools (Profiler/Timeline)
Type:
enhancement

Tracking

(firefox64 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: yulia, Assigned: yulia)

References

Details

(Whiteboard: dt-fission)

Attachments

(1 file, 1 obsolete file)

Bug 1494605 - Use target.getFront for PerformanceFront in tests; r=ochameau
(deleted), text/x-phabricator-request
ochameau
: review+
Details
Example refactoring from front instantiation to getFront --> https://phabricator.services.mozilla.com/D4579 * PerformanceFront: https://searchfox.org/mozilla-central/search?q=PerformanceFront(&case=false&regexp=false&path= Only tests as bug 1222047 already refactored production callsites. It may be useful to migrate initPerformance/destroyPerformance pieces to fronts. https://searchfox.org/mozilla-central/rev/3fa761ade83ed0b8ab463acb057c2cf0b104689e/devtools/client/framework/toolbox.js#3087-3116
Depends on D7060
Comment on attachment 9012537 [details] Bug 1494605 - Use target.getFront for PerformanceFront in tests; r=ochameau Alexandre Poirot [:ochameau] has approved the revision.
Attachment #9012537 - Flags: review+
Assignee: nobody → ystartsev
Component: WebGL Shader Editor → Performance Tools (Profiler/Timeline)
Attachment #9012538 - Attachment is obsolete: true
Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cb8b8676ee77 Use target.getFront for PerformanceFront in tests; r=ochameau
Backout by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f394dec25673 Backed out changeset cb8b8676ee77 as per Yulia`s request.
Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0a653b330b03 Use target.getFront for PerformanceFront in tests; r=ochameau
https://hg.mozilla.org/mozilla-central/rev/0a653b330b03
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Whiteboard: dt-fission
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: