Open Bug 1499134 Opened 6 years ago Updated 2 years ago

In debugger-client.js, the rejected promise should hold a real error value

Categories

(DevTools :: Framework, task, P3)

Product:
DevTools
Component:
Framework
Type:
task

Tracking

(Not tracked)

People

(Reporter: julienw, Unassigned)

Details

In [1] we reject the promise using the returned value, which is written in [2]. We should reject with a real Error instead of rejecting with the received object. [1] https://searchfox.org/mozilla-central/rev/c9272ef398954288525e37196eada1e5a93d93bf/devtools/shared/client/debugger-client.js#583-585 [2] https://searchfox.org/mozilla-central/rev/c9272ef398954288525e37196eada1e5a93d93bf/devtools/shared/protocol.js#1040-1051
Severity: normal → enhancement
Component: General → Debugger
Blocks: dbg-68
Priority: -- → P2
Type: enhancement → task
Component: Debugger → Framework
Priority: P2 → P3

CC yulia, this might be interesting for you.

Flags: needinfo?(ystartsev)
No longer blocks: dbg-68

I don't have spare cycles at the moment so I won't be able to do this. But this might be a good contributor project.

Flags: needinfo?(ystartsev)
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.