Closed Bug 1508306 Opened 6 years ago Closed 4 years ago

Disable the Large-Allocation header for Fission, and migrate to DocumentLoadListener

Categories

(Core :: DOM: Content Processes, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla79
Fission Milestone M6b
Tracking Status
firefox79 --- fixed

People

(Reporter: tjr, Assigned: nika)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

With Fission; I don't think we should need this header anymore. (Unless we want to support it for an origin that has a bunch of heavy tabs open already and wants to do something huge? But that itself might be restricted by the requirement of "any two similar-origin documents (documents with eTLD+1 matching) which are in the same Unit of Related Browsing Contexts (browsing contexts connected by "opener" or "parent/child" relationships) must be co-located in the same process, due to potential synchronous full-DOM access.")
Component: DOM → DOM: Content Processes
Priority: -- → P3

We want to disable support Large-Allocation header for Fission. kmag says we want to remove it after Fission.

Fission Milestone: --- → M6
Summary: Re-evaluate the Large-Allocation Header → Disable the Large-Allocation header for Fission
Depends on: 1522639

Deferring to Fission Beta (M7) because disabling the Large-Allocation header does not need to block enabling in Nightly (M6).

Fission Milestone: M6 → M7

While working on process switch code for bug 1640019, I frequently ran into my old Large-Allocation code as an annoying edge case in the logic. In addition, when I originally wrote Large-Allocation support, DocumentChannel and the other process-switching tools we added for Fission were not available, so it ended up being quite complicated.

I'm morphing this bug to both disable Large-Allocation when Fission is enabled, as well as migrate the implementation from the previous reloadInFreshProcess implementation to instead using DocumentLoadListener.

Assignee: nobody → nika
Fission Milestone: M7 → M6b
Summary: Disable the Large-Allocation header for Fission → Disable the Large-Allocation header for Fission, and migrate to DocumentLoadListener

This removes the diagnostic warnings which used to be logged when the
Large-Allocation header was present, but failed to switch into a
Large-Allocation process. Due to the low adoption of the header, this shouldn't
be too large of a problem, but we can look into re-adding the diagnostics if
needed in the future.

The new codepath no longer performs multiple network requests for
Large-Allocation resources, and now relies on the battle-tested
DocumentLoadListener codepath for process switching.

Pushed by nlayzell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b750f1d873cf Part 1: Migate the Large-Allocation handler to DocumentLoadListener, r=mattwoodrow,necko-reviewers,geckoview-reviewers,agi,valentin https://hg.mozilla.org/integration/autoland/rev/8844170ff408 Part 2: Fix Large-Allocation tests for new changes, r=mattwoodrow
Pushed by nlayzell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/006268679079 Part 1: Migate the Large-Allocation handler to DocumentLoadListener, r=mattwoodrow,necko-reviewers,geckoview-reviewers,agi,valentin https://hg.mozilla.org/integration/autoland/rev/d85bd37494ec Part 2: Fix Large-Allocation tests for new changes, r=mattwoodrow
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
Flags: needinfo?(nika)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: