Closed
Bug 1509038
Opened 6 years ago
Closed 6 years ago
[remote-dbg-next] pushServiceWorker no longer working after switching to front
Categories
(DevTools :: about:debugging, enhancement, P1)
DevTools
about:debugging
Tracking
(firefox66 fixed)
RESOLVED
FIXED
Firefox 66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
(Blocks 1 open bug)
Details
Attachments
(6 files)
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
patch
|
jdescottes
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
text/x-phabricator-request
|
Details |
pushServiceWorker is still using the old client.request API
await clientWrapper.request({ to: actor, type: "push" });
However here actor is now null, because the target id is no longer defined for workers. We are reintroducing id in Bug 1500005, however we still need to switch to workerTargetFront.push();
|
Assignee | |
Updated•6 years ago
|
Priority: -- → P2
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Priority: P2 → P1
|
|
Assignee | |
Comment 1•6 years ago
|
||
This is a followup to Bug 1506549 where some of the frontend
code was migrated to listen to worker updates on the content process fronts.
The current about:debugging was migrated, but not the new one.
|
|
Assignee | |
Comment 2•6 years ago
|
||
Depends on D14074
The current code using request works now that actor points to a real
actor ID, so this doesn't really fix anything. It is a cleanup because we should
move away from using the request API. Also the current about:debugging uses
front.push() so this is better for consistency.
|
|
Assignee | |
Comment 3•6 years ago
|
||
Depends on D14075.
allowChromeProcess will allow to retrieve workers from children processes
|
|
Assignee | |
Comment 4•6 years ago
|
||
Depends on D14077
This test is a conversion of devtools/client/aboutdebugging/test/browser_service_workers_push.js
It turns out I forgot to file a bug to migrate this test, so doing it here.
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/88e3a35b9cfd
Listen to worker updates on contentProcess fronts;r=daisuke
https://hg.mozilla.org/integration/autoland/rev/16264280c0ee
Use worker front push() in aboutdebugging-new;r=daisuke
https://hg.mozilla.org/integration/autoland/rev/2270b8df4dc6
Set allowChromeProcess to true when starting local DebuggerServer;r=daisuke
https://hg.mozilla.org/integration/autoland/rev/25d0bf121f26
Port serviceworker push test to new about:debugging;r=daisuke
|
|
Assignee | |
Comment 6•6 years ago
|
||
Attachment #9030719 -
Flags: review+
|
|
Assignee | |
Comment 7•6 years ago
|
||
Depends on D14078
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1ed80c7a5ce9
Update client wrapper mocks;r=ladybenko
|
||
Comment 9•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/88e3a35b9cfd
https://hg.mozilla.org/mozilla-central/rev/16264280c0ee
https://hg.mozilla.org/mozilla-central/rev/2270b8df4dc6
https://hg.mozilla.org/mozilla-central/rev/25d0bf121f26
https://hg.mozilla.org/mozilla-central/rev/1ed80c7a5ce9
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in
before you can comment on or make changes to this bug.
Description
•