These are the differences between the files I've copied from mozilla-central (after part 3 of bug 857456), and how they are now.

Comment on attachment 9028476 [details] [diff] [review] 1510097-bootstrapped-move-1.diff There's a few new things in here that don't show up in the other diff.

Comment on attachment 9028476 [details] [diff] [review] 1510097-bootstrapped-move-1.diff Review of attachment 9028476 [details] [diff] [review]: ----------------------------------------------------------------- You really jumped right in! Note that some things got renamed in the patches on bug 857456, sorry if it wasn't clear that those were works-in-progress that might change before landing.

Well, having this stuff working is rather important to us. Half of our tests die if it isn't. Now that I've figured out all the issues, rebasing should be easy enough.

This must land with the next inbound-to-central merge or Mozmill will die a horrible death.

Same as before, the difference between part 3 of bug 857456 and this bug. Probably not much use any more, but here we are.

(In reply to Geoff Lankow (:darktrojan) from comment #6) > This must land with the next inbound-to-central merge or Mozmill will die a > horrible death. It wouldn't be the first time it stopped working for a while, like when non-bootstrapped extensions stopped working and we made MozMill and JS Bridge bootstrapped in a hurry. That said, I'll land it.

Comment on attachment 9028796 [details] [diff] [review] 1510097-bootstrapped-move-2.diff Review of attachment 9028796 [details] [diff] [review]: ----------------------------------------------------------------- ::: common/src/BootstrapLoader.jsm @@ +1,1 @@ > + has a blank line on top. but, should add the MPL notice ::: common/test/xpcshell/data/BootstrapMonitor.jsm @@ +1,1 @@ > +ChromeUtils.import("resource://gre/modules/Services.jsm"); this file too should have a license ::: common/test/xpcshell/head_addons.js @@ +690,5 @@ > + actualValue.toSource() + ")"); > + } > + > + return; > + } else if (expectedValue && !actualValue) { no else after return @@ +1249,5 @@ > +Services.prefs.setBoolPref(PREF_XPI_SIGNATURES_REQUIRED, false); > + > +Services.prefs.setBoolPref("extensions.legacy.enabled", true); > + > + extra blank line @@ +1279,5 @@ > + }; > +} > + > +/** > + * Change the schema version of the JSON extensions database these documentations could add a period at the end ::: common/test/xpcshell/test_bootstrap.js @@ +31,5 @@ > +userExtDir.append("extensions2"); > +userExtDir.append(gAppInfo.ID); > +registerDirectory("XREUSysExt", userExtDir.parent); > + > + extra blank line @@ +154,5 @@ > + } > + equal(data.size, 0); > +} > + > + and here

Comment on attachment 9028797 [details] [diff] [review] 1510097-diff-2.diff Review of attachment 9028797 [details] [diff] [review]: ----------------------------------------------------------------- This is toolkit/ - someone from there should review

Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/9a6732b236da Move bootstrapped extension and install.rdf handling to comm-central. r=mkmelin

That was just a *total success* !! \o/

Yes, thank you Andrew, for making that process so easy.

Cheers, I'm glad to hear that...