Closed Bug 1512445 Opened 6 years ago Closed 6 years ago

Import Windows AudioIPC changes and enable in build (but leave disabled via pref)

Categories

(Core :: Audio/Video: cubeb, enhancement, P2)

Product:
Core
Component:
Audio/Video: cubeb
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: kinetik, Assigned: kinetik)

References

Details

Attachments

(3 files)

Bug 1512445 - Import latest AudioIPC from upstream, including Windows backend. r=chunmin
(deleted), text/x-phabricator-request
Details
Bug 1512445 - Re-vendor Rust dependencies for AudioIPC. r=chunmin
(deleted), text/x-phabricator-request
Details
Bug 1512445 - Enable AudioIPC build on Windows (default off via pref). r=chunmin
(deleted), text/x-phabricator-request
Details
This covers landing the remaining work. I'll leave bug 1432303 for actually prefing the code on. Main patches awaiting review: https://github.com/kinetiknz/audioipc-2/pull/3 There's also some integration changes (vendoring, build config changes) on the Gecko side which show up in the Try push - I'll get those bits up for review shortly: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5a1047c8a400ddd47456ff25b8c176a10013452e Currently investigating the Windows test failures.
Rank: 15
Priority: -- → P2

https://github.com/kinetiknz/audioipc-2/pull/3 reviewed and merged to master (https://github.com/djg/audioipc-2).

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=51b835ba596edee2058f47c32393bc7ba07e7110

Note this is with the code still disabled on Windows. Need to finish following up on remaining test failures for Windows (and macOS) before preffing on. Deps of bug 1432303 will track the other parts.

Depends on D22153

Pushed by mgregan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0a78b7e72e1b Import latest AudioIPC from upstream, including Windows backend. r=chunmin https://hg.mozilla.org/integration/autoland/rev/04c1982c1a7e Re-vendor Rust dependencies for AudioIPC. r=chunmin https://hg.mozilla.org/integration/autoland/rev/b954e5d0324a Enable AudioIPC build on Windows (default off via pref). r=chunmin
Summary: Import Windows AudioIPC changes and enable in build → Import Windows AudioIPC changes and enable in build (but leave disabled via pref)

winapi 0.2.x doesn't work on aarch64 windows...but audioipc has a number of dependencies which still use winapi 0.2.x, notably mio, whose maintainers appear in no hurry to update (cf. https://github.com/carllerche/mio/issues/658 and https://github.com/carllerche/iovec/issues/16). :(

MinGW fix looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9ec9b0e0a6ff76e1d3f83936b5db0f761eb54712

I'll disable the Windows aarch64 builds for now: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8efaf382c4703950de6b8e4b11e0101d243474a8

I'm not sure what to do about the winapi 0.2.x issue longer term - waiting on upstream doesn't seem feasible based on the progress in those PRs. Could we get away with creating a shim winapi 0.2.x for the (hopefully small) set of items needed by these crates that redirects to the implementations in winapi 0.3.x?

Attachment #9048621 - Attachment is obsolete: true
Attachment #9048620 - Attachment is obsolete: true
Attachment #9048622 - Attachment is obsolete: true
Attachment #9048620 - Attachment is obsolete: false
Attachment #9048621 - Attachment is obsolete: false
Attachment #9048622 - Attachment is obsolete: false
Pushed by mgregan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/25eb307eb4ed Import latest AudioIPC from upstream, including Windows backend. r=chunmin https://hg.mozilla.org/integration/autoland/rev/ab9a152e934d Re-vendor Rust dependencies for AudioIPC. r=chunmin https://hg.mozilla.org/integration/autoland/rev/ea127c95a4b9 Enable AudioIPC build on Windows (default off via pref). r=chunmin

I'll disable the Windows aarch64 builds for now: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8efaf382c4703950de6b8e4b11e0101d243474a8

Relanded (after fighting with Phabricator/Lando for some time) with the minor build changes tested in the above try push.

Bug 1533220 for aarch64.

https://hg.mozilla.org/mozilla-central/rev/25eb307eb4ed
https://hg.mozilla.org/mozilla-central/rev/ab9a152e934d
https://hg.mozilla.org/mozilla-central/rev/ea127c95a4b9

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Depends on: 1533664
Depends on: 1533539
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: