Closed Bug 1516475 Opened 6 years ago Closed 6 years ago

Bouncerscript support for Thunderbird MSI files

Categories

(Thunderbird :: Build Config, enhancement)

Product:
Thunderbird
Component:
Build Config
Platform:
All
Windows
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Paenglab, Assigned: rjl)

References

Details

From bug 274624 comment 13: Looks pretty reasonable. I suspect that since this is touching release-bouncer things that something will need to happen with the release-bouncer itself so that it recognizes the new aliases. If you want to open a separate bug for me I'll look into it.
This is the pull request for bouncerscript that added support for the Firefox MSI packages. https://github.com/mozilla-releng/bouncerscript/pull/43
Blocks: 274624
No longer depends on: 274624
Summary: Add in release-bouncer the needed thing for bug 274624 → Bouncerscript support for Thunderbird MSI files
Blocks: 1516741

Pull request for Thunderbird MSI support in Bouncerscript: https://github.com/mozilla-releng/bouncerscript/pull/53

Flags: needinfo?(bugspam.Callek)

There is a linting failure that needs fixing (or ignoring - if mihai says it is fine) - though I'm not authorized to merge the PR anyway, so handing the n-i off to mihai

Flags: needinfo?(bugspam.Callek) → needinfo?(mtabara)

(In reply to Justin Wood (:Callek) from comment #3)

There is a linting failure that needs fixing (or ignoring - if mihai says it is fine) - though I'm not authorized to merge the PR anyway, so handing the n-i off to mihai

I suppose we can ignore that since the others are alike. OR bump that limit. Or make all those consistenc with :rjl's solution. Regardless, I'd be good to add those entries in the tests as well, along the others to ensure regexes still work.

Other than that, I'm not sure we actually need the next alias. Do we want to update that?
I can help with creating those in bouncer + deployment when this is ready.

Leaving the NI to myself here as a reminder until we close the bug.

Removing the NI, feel free to flag me again when ready.

Flags: needinfo?(mtabara)

:rjl - deployed the changes in bouncerscript. I can create the alias entries in bouncer. Which versions should they point to, initially?

Flags: needinfo?(rob)

For now we are not creating the aliases as there are no good MSI packages to point them at. Mihai checked the code server-side and confirmed that the aliases are created automatically on first submit, so all that needs to be done is update the release-bouncer-*/kind.yml files once ready.

Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(rob)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.