QuantumBar: One-off search buttons aren't hidden when an "@engine" search alias is entered
Categories
(Firefox :: Address Bar, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: standard8, Assigned: adw)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
When entering a search alias, the one-off search buttons are not hidden on QuantumBar.
STR:
- Enter "@" in the address bar
Expected Results
=> List of aliases with one-off buttons hidden.
Actual Results
=> List of aliases with one-off buttons displayed.
|
Reporter | |
Comment 1•6 years ago
|
||
Note: when we fix this, we should enable assertOneOffButtonsVisible in browser_urlbarSearchFunction.js for QuantumBar and hiddenWhenUsingSearchAlias in browser_urlbarOneOffs.js.
|
|
Reporter | |
Comment 2•6 years ago
|
||
Just updated the previous comment - I'm going to be implementing a better way of checking the visible status in bug 1527940, so adding dependency.
|
||
Updated•6 years ago
|
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Comment 3•6 years ago
|
||
This happens here in the awesomebar for reference: https://searchfox.org/mozilla-central/rev/8e8ccec700159dc4efe061cfec2af10b21a8e62a/browser/base/content/urlbarBindings.xml#2486
|
|
Assignee | |
Comment 4•6 years ago
|
||
This is based on bug 1528430 and bug 1527947.
|
|
Assignee | |
Updated•6 years ago
|
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
Description
•