Remove uses of ChromeUtils.import(..., null) in extensions code
Categories
(WebExtensions :: General, task, P3)
Tracking
(firefox95 fixed)
Tracking | Status | |
---|---|---|
firefox95 | --- | fixed |
People
(Reporter: robwu, Assigned: mathew.hodson)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
There are dozens of uses of ChromeUtils.import
with null
as the second parameter. This is deprecated, so we should move away from it.
28 occurrences use Management
, which can simply be replaced with ExtensionParent.apiManager
. There are probably also a few other simple fixes, and some possibly more difficult cases.
Updated•6 years ago
|
Updated•6 years ago
|
Reporter | ||
Updated•6 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
Simplify some instances where modules were lazy loaded.
Updated•3 years ago
|
Comment 2•3 years ago
|
||
Hi Mathew, are you still working on this? The other patch that I mentioned in Phabricator landed a while ago.
Assignee | ||
Comment 3•3 years ago
|
||
I'm still planning to work on it. It might take me some time because I need to setup my environment and rebase.
Reporter | ||
Comment 4•3 years ago
|
||
(In reply to Mathew Hodson from comment #3)
I'm still planning to work on it. It might take me some time because I need to setup my environment and rebase.
If you're looking for a written guide, see the section and/or linked documentation at https://wiki.mozilla.org/WebExtensions/Contribution_Onramp#Setting_Up_Developer_Environment
Comment 5•3 years ago
|
||
Just to note, I'm going to be filing bugs to fix the other import rule failures referenced in the .eslintrc.js file, so you may come across bitrot there.
Also, I've just been told that it would be useful to have this within the next few weeks, as we are hoping to move forward with work that this enables.
Updated•3 years ago
|
Comment 7•3 years ago
|
||
bugherder |
Comment 8•3 years ago
|
||
Thank you for working on, that's a really nice big bit of clean-up to have done.
Assignee | ||
Updated•3 years ago
|
Description
•