Closed Bug 1536708 Opened 6 years ago Closed 5 years ago

Conditional jump or move depends on uninitialized values in [@ mp4parse::read_sinf]

Categories

(Core :: Audio/Video: Playback, defect, P2)

defect

Tracking

()

RESOLVED FIXED
Tracking Status
firefox68 --- affected

People

(Reporter: tsmith, Unassigned)

References

(Blocks 1 open bug)

Details

(4 keywords)

Attachments

(1 file)

Attached video testcase.mp4 (deleted) —

This was found while testing with m-c:
BuildID=20190318220034
SourceStamp=2abb636ad481768b7c88619080cf224b2c266b2d

==114823== Conditional jump or move depends on uninitialised value(s)
==114823==    at 0x140FCAE4: mp4parse::read_sinf (ptr.rs:204)
==114823==    by 0x140F4150: mp4parse::read_stsd (lib.rs:1988)
==114823==    by 0x140EDA29: mp4parse::read_mdia (lib.rs:976)
==114823==    by 0x140E7377: mp4parse::read_moov (lib.rs:870)
==114823==    by 0x140E4C11: mp4parse_read (lib.rs:729)
==114823==    by 0x11D3D5A3: mozilla::MP4Metadata::Parse() (MP4Metadata.cpp:102)
==114823==    by 0x11D3C2F0: mozilla::MP4Demuxer::Init() (MP4Demuxer.cpp:145)
==114823==    by 0x11B019E3: mozilla::detail::ProxyFunctionRunnable<mozilla::MediaFormatReader::DemuxerProxy::Init()::$_15, mozilla::MozPromise<mozilla::MediaResult, mozilla::MediaResult, true> >::Run() (MediaFormatReader.cpp:898)
==114823==    by 0xFD42D43: mozilla::TaskQueue::Runner::Run() (TaskQueue.cpp:199)
==114823==    by 0xFD533B3: nsThreadPool::Run() (nsThreadPool.cpp:241)
==114823==    by 0xFD534FC: non-virtual thunk to nsThreadPool::Run() (nsThreadPool.cpp:0)
==114823==    by 0xFD4FCD7: nsThread::ProcessNextEvent(bool, bool*) (nsThread.cpp:1179)
==114823==  Uninitialised value was created by a stack allocation
==114823==    at 0x140FB9BA: mp4parse::read_sinf (lib.rs:2198)
==114823==
Flags: in-testsuite?
Rank: 15
Priority: -- → P2
Keywords: sec-low
Keywords: testcase, valgrind

This is likely a false positive that was recently fixed in Valgrind. I can confirm this is no longer reproducible with the latest version of Valgrind.

I tested with m-c 20200102-c7082b580eeb and Valgrind commit 2a7d3ae7681.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: