Stopped for thrown exception. $[0] = [XPComponent] [class: XPCWrappedNative_NoHelper] {0} function sidebar_overlay_init() in <chrome://communicator/content/sidebar/sidebarOverlay.js> line 774 772: // the individual panel's title, customize URL, and content URL. 773: var panels = document.getElementById('sidebar-panels'); 774: panels.database.AddDataSource(RDF.GetDataSource(sidebarObj.datasource_uri)); 775: 776: debug("Adding observer to database."); $[0].stringValue [Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIRDFService.GetDataSource]" nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)" location: "JS frame :: chrome://communicator/content/sidebar/sidebarOverlay.js :: sidebar_overlay_init :: line 774" data: no] sidebarObj.datasource_uri $[1] = [null] null

timeless, Did you mean to only add the patch for sidebarOverlay.js?

well, probably, although i'd like to do the other cleanup, would you review? (i'll do whichever you request)

Comment on attachment 88850 [details] [diff] [review] only do work if sidebarObj.datasource_uri isn't null r=sgehani contingent upon (a) take out the comment (or whittle it down to what's necessary) in cutomize.js (b) test the customize dialog thoroughly (c) test the sidebar thoroughly: especially visibility changes: collapsed <-> displayed <-> hidden completely

Comment on attachment 88850 [details] [diff] [review] only do work if sidebarObj.datasource_uri isn't null bitrot

My steps: Enable QuickLaunch, Close all windows, (let Mozilla QL-icon restart itself), Open Navigator from the QL-icon. [Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b) Gecko/20050121] (nightly) (W98SE) [Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a6) Gecko/20050111] (release) (W98SE) [Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a5) Gecko/20041122] (release) (W98SE) {{ Error: [Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIRDFService.GetDataSource]" nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)" location: "JS frame :: chrome://communicator/content/sidebar/sidebarOverlay.js :: sidebar_open_default_panel :: line 821" data: no] Source File: chrome://communicator/content/sidebar/sidebarOverlay.js Line: 821 }} [Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7.5) Gecko/20041217] (release) (W98SE) No exception. My case looks like a regression, but not making as is, since this bug was opened in 2002 :-/

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a5) Gecko/20041122] (release) (W98SE) This patch fixes the exception, yet, I made a guess as how to properly fix the bitrotting... Could you test/(super-)review/check in this patch ? Thanks.

Comment on attachment 172052 [details] [diff] [review] (Bv1) <sidebarOverlay.js> Under the current SeaMonkey review rules, you may only need review from Mnyromyr and no SR.

timeless, what would be the steps to reproduce ? http://mxr.mozilla.org/comm-central/source/suite/common/sidebar/sidebarOverlay.js It seems 741 sidebarObj.datasource_uri = get_sidebar_datasource_uri(); can only be null if 941 function get_sidebar_datasource_uri() { caught an exception. NB: My comment 6 steps don't apply to 1.9.1 trunk anymore, as QL feature was dropped (afaik).

Comment on attachment 172052 [details] [diff] [review] (Bv1) <sidebarOverlay.js> Removing review requests for now.