Closed
Bug 1540990
Opened 6 years ago
Closed 6 years ago
Get rid of unnecessary nsIPresShell.h inclusions
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
No description provided.
|
Assignee | |
Comment 1•6 years ago
|
||
A lot of files include nsIPresShell.h even though currently they don't
need it. This patch removes the unnecessary inclusions.
|
|
Assignee | |
Updated•6 years ago
|
Blocks: includehell
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/3b94c20ba873
Get rid of unnecessary nsIPresShell.h inclusions r=emilio
|
||
Comment 3•6 years ago
|
||
Backed out for build bustages.
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=237985844&repo=autoland&lineNumber=19821
Backout: https://hg.mozilla.org/integration/autoland/rev/d63733e7f42fc5da3b8896099b69bef27456ddbe
Flags: needinfo?(masayuki)
|
|
Assignee | |
Comment 4•6 years ago
|
||
Looks like that some cpp files don't include necessary nsIPresShellInlines.h directly. So, something was changed by other changes which made such files include it indirectly.
Flags: needinfo?(masayuki)
|
|
Assignee | |
Comment 5•6 years ago
|
||
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/e875e0c671bf
Get rid of unnecessary nsIPresShell.h inclusions r=emilio
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in
before you can comment on or make changes to this bug.
Description
•