Closed
Bug 1544218
Opened 6 years ago
Closed 6 years ago
Make apzc use mozilla::PresShell directly rather than via nsIPresShell
Categories
(Core :: Graphics: Layers, task)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(4 files)
No description provided.
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
|
|
Assignee | |
Comment 3•6 years ago
|
||
|
|
Assignee | |
Comment 4•6 years ago
|
||
And this patch makes it return raw pointer. The safeness of the pointer
should be managed by MOZ_CAN_RUN_SCRIPT since incrementing refcount in
hot path is bad for performance. So, it should be followed by bug 1543315.
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/2a5c7852f148
part 1: Make mozilla::layers::GetPresShell() in APZCCallbackHelper.cpp return mozilla::PresShell directly r=kats
https://hg.mozilla.org/integration/autoland/rev/06908f47b337
part 2: Make APZCCallbackHelper::GetRootContentDocumentPresShellForContent() return mozilla::PresShell directly r=kats
https://hg.mozilla.org/integration/autoland/rev/359c63f6aa5e
part 3: Make FocusTarget use mozilla::PresShell directly rather than via nsIPresShell r=kats
https://hg.mozilla.org/integration/autoland/rev/fe7c0d7c09e5
part 4: Make remaining APZC code use mozilla::PresShell directly rather than nsIPresShell r=kats
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2a5c7852f148
https://hg.mozilla.org/mozilla-central/rev/06908f47b337
https://hg.mozilla.org/mozilla-central/rev/359c63f6aa5e
https://hg.mozilla.org/mozilla-central/rev/fe7c0d7c09e5
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in
before you can comment on or make changes to this bug.
Description
•