Make layout use mozilla::PresShell directly rather than via nsIPresShell
Categories
(Core :: Layout, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(3 files, 1 obsolete file)
|
Assignee | |
Comment 1•6 years ago
|
||
And this patch makes it return raw pointer. The safeness of the pointer
should be managed by MOZ_CAN_RUN_SCRIPT since incrementing refcount in
hot path is bad for performance. So, it should be followed by bug 1543315.
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9058204 [details]
Bug 1544343 - part 1: Make mozilla::layers::GetPresShell() in APZCCallbackHelper.cpp return mozilla::PresShell directly
Revision D27471 was moved to bug 1544218. Setting attachment 9058204 [details] to obsolete.
|
|
Assignee | |
Comment 3•6 years ago
|
||
|
|
Assignee | |
Comment 4•6 years ago
|
||
Additionally, this patch makes nsFrame.h stop including nsIPresShell.h
and makes each users include mozilla/PresShell.h instead. So, this improves
rebuild performance of nsIPresShell.h (and mozilla/PresShell.h in the
future).
Note that due to nsIFrame::PresShell(), mozilla:: prefix is necessary for
PresShell in a lot of classes which are derived from nsIFrame even in
.cpp files.
|
|
Assignee | |
Comment 5•6 years ago
|
||
This patch changes remaining things under layout/. However, there are some
places which still need to use nsIPresShell. That will be fixed in a
follow up bug.
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/cfd46a25af71
https://hg.mozilla.org/mozilla-central/rev/4b56de3cd46c
https://hg.mozilla.org/mozilla-central/rev/35aed2f899c3
Description
•