Define all enums for nsIPresShell and mozilla::PresShell in new header file
Categories
(Core :: Layout, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(3 files)
I think that there should be new header file mozilla/PresShellForwards.h
as similar to mozilla/EventForwards.h
. It should have forward declarations of all classes and structs in mozilla/PresShell.h
and nsIPresShell.h
. And it should declare all enums and constatns of them as enum classes. Then, when a header requires only them, they don't need to include mozilla/PresShell.h
nor nsIPresShell.h
anymore.
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
This patch creates new header, mozilla/PresShellForwards.h
. It should have
all forward declarations of global class/struct in nsIPresShell.h
and
mozilla/PresShell.h
.
Additionally, this moves all enum
s and constant
s in them into the new file
with changing them to enum class
es.
This will make other headers which require only specific types in the header
files not include them.
Assignee | ||
Comment 2•6 years ago
|
||
This patch moves some enum
in nsIPresShell
which are in public scope into
mozilla
namespace and change them as enum class
es.
Unfortunately, only "where to scroll" enum is just defines constants of
percentages of scroll destination. Therefore, this patch makes only them
as static const
.
Assignee | ||
Comment 3•6 years ago
|
||
This patch moves remaining public enum
of nsIPresShell
to mozilla
namespace in mozilla/PresShellForwards.h
and make them enum class
es.
Additionally, some methods which use the moving enum
s from nsIPresShell
to PresShell
.
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/97f1fb7c02bd
https://hg.mozilla.org/mozilla-central/rev/ac28f88b0c67
https://hg.mozilla.org/mozilla-central/rev/e73708ef8eba
Description
•