Stop using [array] in password manager idl
Categories
(Toolkit :: Password Manager, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(5 files)
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Comment 1•6 years ago
|
||
I audited all the callsites
https://searchfox.org/mozilla-central/search?q=%5B%5EA-Za-z_%5D%5BGg%5DetAllLogins%5B%5EA-Za-z_%5D&case=true®exp=true&path=
brings up.
|
|
Assignee | |
Comment 2•6 years ago
|
||
|
|
Assignee | |
Comment 3•6 years ago
|
||
|
|
Assignee | |
Comment 4•6 years ago
|
||
|
|
Assignee | |
Comment 5•6 years ago
|
||
|
||
Comment 6•6 years ago
|
||
There is another consumer outside of the tree which is the Lockwise extension but it doesn't look like it would be broken by these changes as it doesn't use findLogins or searchLogins AFAICT. It shouldn't be a problem for the initial extension release and that code is getting ported in-tree now so won't have to deal with cross-version compatibility in the future.
|
|
||
Updated•6 years ago
|
|
||
Comment 8•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5a94b7075dda
https://hg.mozilla.org/mozilla-central/rev/40d655af6177
https://hg.mozilla.org/mozilla-central/rev/288bafa86adb
https://hg.mozilla.org/mozilla-central/rev/bdbfb93093ee
https://hg.mozilla.org/mozilla-central/rev/bbbbed508f9b
|
||
Comment 9•6 years ago
|
||
Boris, could you please check C-C usage and CC me on the respective bugs to avoid being hit by something like bug 1552059 (at midnight). Looking at bug 1509981, there are a few more in the works. Four if I count correctly: profiler, places, layout history and controller. Or I could check it now.
|
|
Assignee | |
Comment 10•6 years ago
|
||
I'll try, but for some of these things finding the uses is not trivial (esp. in JS, where the compiler won't catch it for you), and I don't really have time for full c-c audits. You may need to track along and look for c-c JS uses yourself...
As for C++ uses, unfortunately there is no good code-search solution for c-c that will Just Show Them like searchfox does for m-c. Again, I'll see if full-text search shows few enough hits that it's obvious, but no guarantees.
Description
•