Closed Bug 1557645 Opened 5 years ago Closed 4 years ago

Basic support for OOP-iframes in print preview

Categories

(Core :: Printing: Setup, defect, P2)

defect

Tracking

()

RESOLVED FIXED
83 Branch
Fission Milestone M6c
Tracking Status
firefox82 --- wontfix
firefox83 --- fixed

People

(Reporter: jwatt, Assigned: emilio)

References

(Depends on 1 open bug)

Details

(Whiteboard: [layout:backlog:2020][print2020_v83])

Attachments

(3 files)

A logical milestone on the way to getting printing fully working with out-of-process iframes is to get print preview working with OOP-iframes. Once that is working, getting printing fully working will mostly "just" be about interleaving and positioning of draw recordings from the various processes.

Status: NEW → ASSIGNED
Fission Milestone: --- → M4
Fission Milestone: M4 → M5

M6 because printing support blocks enabling Fission in Nightly. Neha says print preview doesn't need to block dogfooding (M5).

Fission Milestone: M5 → M6
Depends on: 1587459
Depends on: 1432651
Whiteboard: [layout:backlog:2020q1]

This will likely involve replacing the current setup code with something based on ManagedEndpoint.

Summary: Basic support for OOP-iframes in print preview → Basic support for OOP-iframes in print preview (reimplement static cloning using a ManagedEndpoint)
No longer depends on: 1557638
Depends on: 1621140
Depends on: 1140929
No longer depends on: 1587459

Tracking for Fission Nightly (M6c)

Fission Milestone: M6 → M6c
Depends on: 1640533
Depends on: 1597466
Depends on: 1597484
Depends on: 1640766
Depends on: 1640768
Whiteboard: [layout:backlog:2020q1] → [layout:backlog:2020q1][print2020_v81]
Whiteboard: [layout:backlog:2020q1][print2020_v81] → [layout:backlog:2020][print2020_v82]
Fission Milestone: M6c → M6b
Summary: Basic support for OOP-iframes in print preview (reimplement static cloning using a ManagedEndpoint) → Basic support for OOP-iframes in print preview
No longer depends on: 1597466
No longer depends on: 1140929
No longer depends on: 1432651

Sean said fission printing work will most probably not be ready in time for nightly experiment and we shouldn't block on it. It is expected to be fixed in a couple of weeks following the experiment launch.

Fission Milestone: M6b → M6c
Whiteboard: [layout:backlog:2020][print2020_v82] → [layout:backlog:2020][print2020_v83]
Assignee: jwatt → emilio

This seems to work (as in, I correctly process-switch the iframe and hit
the printf in the right process). I didn't hook up the cloning just yet,
but it should be relatively doable.

Comment on attachment 9175870 [details]
Bug 1557645 - Clone OOP iframes in the right process. r=nika,mattwoodrow

Matt, Nika, I think you're familiar with the process-switching logic that I'm touching here. Does this look reasonable?

For actual printing, we may want to provide some clone completion callback or something of that sort, perhaps, but for print preview I think hooking up the cloning is the last bit missing here.

Attachment #9175870 - Flags: feedback?(nika)
Attachment #9175870 - Flags: feedback?(matt.woodrow)

Just minor preliminar cleanup.

By passing the content viewer to CreateStaticClone we can do this fairly
easily. I'm going to add another entry-point to the clone process and
it'd be good if we avoid repeating the SetDocument dance and so on.

Depends on D90314

Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/142bea7765f9 Document::CreateStaticClone shouldn't be virtual. r=jwatt
Keywords: leave-open
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0d33b3a1a7db Unify in-process document cloning a bit more. r=jwatt
Attachment #9175870 - Attachment description: Bug 1557645 - WIP - Clone OOP iframes in the right process. → Bug 1557645 - Clone OOP iframes in the right process. r=nika,mattwoodrow

Comment on attachment 9175870 [details]
Bug 1557645 - Clone OOP iframes in the right process. r=nika,mattwoodrow

replied on the review

Attachment #9175870 - Flags: feedback?(nika) → feedback+
Attachment #9175870 - Flags: feedback?(matt.woodrow)
Keywords: leave-open
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/713a1bb30a6d Clone OOP iframes in the right process. r=nika
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
Regressions: 1669554
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: