Closed Bug 1557854 Opened 5 years ago Closed 5 years ago

Remove unused get/setColorMatrix bits on docshell

Categories

(Core :: DOM: Navigation, defect, P2)

defect

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox69 --- affected

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(1 obsolete file)

No description provided.

Boris, this bug has a patch about a month old. Should we ping the reviewer or have someone else review?

Flags: needinfo?(bzbarsky)
Priority: -- → P2

Eitan's bugzilla name says he's gone until "mid/late June", and he currently has needinfo requests blocked, so it sounds like he's not back yet?

This isn't really urgent yet, so I wasn't worrying about it too much. The original commit to add these methods was reviewed by smaug, but I was trying to avoid dumping more reviews on his plate.

Flags: needinfo?(bzbarsky)

Hi Boris.

It looks like we have a devtools feature we are looking into that might take advantage of this.

Maliha our intern can elaborate. I guess it is worth holding off on removing this.

Hello,
I am currently working on Bug 1564966 that will add a feature in the devtools accessibility panel to simulate different types of color blindness. This requires applying a color matrix filter to the entire document and so, the get/setColorMatrix methods on docshell would definitely come handy!

OK, not a problem. I filed bug 1566543 on the thing we should do instead, then.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
Attachment #9070722 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: