Remove unused get/setColorMatrix bits on docshell
Categories
(Core :: DOM: Navigation, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox69 | --- | affected |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 obsolete file)
Assignee | ||
Comment 1•5 years ago
|
||
Comment 2•5 years ago
|
||
Boris, this bug has a patch about a month old. Should we ping the reviewer or have someone else review?
Assignee | ||
Comment 3•5 years ago
|
||
Eitan's bugzilla name says he's gone until "mid/late June", and he currently has needinfo requests blocked, so it sounds like he's not back yet?
This isn't really urgent yet, so I wasn't worrying about it too much. The original commit to add these methods was reviewed by smaug, but I was trying to avoid dumping more reviews on his plate.
Comment 4•5 years ago
|
||
Hi Boris.
It looks like we have a devtools feature we are looking into that might take advantage of this.
Maliha our intern can elaborate. I guess it is worth holding off on removing this.
Comment 5•5 years ago
|
||
Hello,
I am currently working on Bug 1564966 that will add a feature in the devtools accessibility panel to simulate different types of color blindness. This requires applying a color matrix filter to the entire document and so, the get/setColorMatrix methods on docshell would definitely come handy!
Assignee | ||
Comment 6•5 years ago
|
||
OK, not a problem. I filed bug 1566543 on the thing we should do instead, then.
Updated•5 years ago
|
Description
•