Closed Bug 1557963 Opened 5 years ago Closed 5 years ago

Stop using [array] in nsIUpdateService

Categories

(Toolkit :: Application Update, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Jorg, this will want a minor change to mail/base/content/aboutDialog-appUpdater.js to remove the (unused) third arg of onCheckComplete and the second arg passed to selectUpdate.

Attached patch 1557963-c-c-part.patch (deleted) — Splinter Review

I can't set r?, but I'll take and f+ as r+ :-) - Thanks for the heads-up.

Attachment #9070797 - Flags: feedback?(bzbarsky)
Attachment #9070797 - Flags: review+
Attachment #9070797 - Flags: feedback?(bzbarsky)
Attachment #9070797 - Flags: feedback+
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a3031bdbf14a Stop using [array] in nsIUpdateService. r=rstrong
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/d81765c682d0 C-C part: Adapt to array changes of nsIUpdateService.onCheckComplete() and .selectUpdate(). r=bz
Regressions: 1558070
No longer regressions: 1558070
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: