Closed
Bug 1562691
Opened 5 years ago
Closed 5 years ago
gURLBarHandler.formatValue() doesn't work with the quantumbar enabled (potentially breaking https strikethrough for active mixed content)
Categories
(Firefox :: Address Bar, defect, P1)
Firefox
Address Bar
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox-esr68 | --- | fixed |
| firefox67 | --- | unaffected |
| firefox68 | --- | fixed |
| firefox69 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression, sec-low)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
jcristau
:
approval-mozilla-release+
jcristau
:
approval-mozilla-esr68+
|
Details |
No description provided.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8b4565507d19
Make gURLBarHandler.formatValue() work with the quantumbar enabled. r=mak
|
|
Assignee | |
Comment 3•5 years ago
|
||
Comment on attachment 9075192 [details]
Bug 1562691 - Make gURLBarHandler.formatValue() work with the quantumbar enabled. r=mak
Beta/Release Uplift Approval Request
- User impact if declined: Afaik this bug could only manifest on secure pages that load active mixed content after the page finished loading, with mixed content protection disabled through the site identity panel (we block active mixed content by default). That makes this tricky to reproduce, and I'm unsure what the real-world impact is. Because of the potential security implications I think we should still uplift this.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: -
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Trivial fix
- String changes made/needed: -
Attachment #9075192 -
Flags: approval-mozilla-beta?
| Comment hidden (obsolete) |
|
|
Assignee | |
Updated•5 years ago
|
status-firefox67:
--- → unaffected
|
|
Assignee | |
Updated•5 years ago
|
Attachment #9075192 -
Flags: approval-mozilla-esr60? → approval-mozilla-esr68?
|
||
Updated•5 years ago
|
Keywords: regression
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
|
||
Updated•5 years ago
|
status-firefox-esr60:
--- → unaffected
status-firefox-esr68:
--- → affected
|
|
Assignee | |
Updated•5 years ago
|
Keywords: sec-low
Summary: gURLBarHandler.formatValue() doesn't work with the quantumbar enabled → gURLBarHandler.formatValue() doesn't work with the quantumbar enabled (potentially breaking https strikethrough for active mixed content)
|
|
Assignee | |
Updated•5 years ago
|
Attachment #9075192 -
Flags: approval-mozilla-beta?
|
|
||
Comment 6•5 years ago
|
||
Comment on attachment 9075192 [details]
Bug 1562691 - Make gURLBarHandler.formatValue() work with the quantumbar enabled. r=mak
quantumbar fix, approved for 68 rc2
Attachment #9075192 -
Flags: approval-mozilla-release?
Attachment #9075192 -
Flags: approval-mozilla-release+
Attachment #9075192 -
Flags: approval-mozilla-esr68?
Attachment #9075192 -
Flags: approval-mozilla-esr68+
|
|
||
Comment 7•5 years ago
|
||
| bugherder uplift | ||
|
|
||
Comment 8•5 years ago
|
||
| bugherder uplift | ||
|
|
||
Updated•3 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•