Closed Bug 1567737 Opened 5 years ago Closed 5 years ago

Crash in [@ InvalidArrayIndex_CRASH | mozilla::layers::AsyncImagePipelineManager::UpdateImageKeys]

Categories

(Core :: Graphics: Layers, defect)

Unspecified
Windows 10
defect
Not set
critical

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox70 + fixed

People

(Reporter: jseward, Assigned: sotaro)

References

Details

(Keywords: crash, regression)

Crash Data

This signature appears in two different installations in the Windows nightly of 20190718215316.

Flags: needinfo?(nical.bugzilla)

Hmm, crash is strange. Crash happens at a place that is using mWrTextureWrapper. But it is not used since Bug 1559284.

(In reply to Sotaro Ikeda [:sotaro] from comment #1)

Hmm, crash is strange. Crash happens at a place that is using mWrTextureWrapper. But it is not used since Bug 1559284.

Bug 1567816 is created for removing WebRenderTextureHostWrapper.

Depends on: 1567816

Fixed by sotaro in bug 1567816.

Assignee: nobody → sotaro.ikeda.g
Flags: needinfo?(nical.bugzilla)

(In reply to Nicolas Silva [:nical] from comment #3)

Fixed by sotaro in bug 1567816.

It did not address the crash. Since bug 1567816 fix, crash report says that the crash happen in a different place in AsyncImagePipelineManager::UpdateImageKeys(). From it, a root cause of the crash seems to exist in a different place.

Tracking to make sure to check up on this in a day or two.

When texture->NumSubTextures() returned 0, it caused the crash by InvalidArrayIndex_CRASH(). It could happen since Bug 1562616 fix.

https://searchfox.org/mozilla-central/source/gfx/layers/wr/AsyncImagePipelineManager.cpp#245

Regressed by: 1562616
No longer regressed by: 1562616
Depends on: 1568419

Since Bug 1568419 fix, crash did not happen.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.