Port bug 1551334 to Thunderbird - Update hiddenWindow.xul on OSX to xhtml
Categories
(Thunderbird :: General, task, P1)
Tracking
(Not tracked)
People
(Reporter: mkmelin, Assigned: khushil324)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
khushil324
:
review+
|
Details | Diff | Splinter Review |
Once bug 1570955 is done, migrate the hidden window.
|
Reporter | |
Comment 1•5 years ago
|
||
The renames are already done. But let's still to the rename to hiddenWindowMac.xhtml and what more is needed to stay more in sync.
|
|
Reporter | |
Comment 2•5 years ago
|
||
Let's do this bug for all the syncing - https://searchfox.org/mozilla-central/source/browser/base/content/macWindow.inc.xhtml
|
|
Reporter | |
Comment 3•5 years ago
|
||
Let's make sure to do this so we don't have surprises, like (maybe) bug 1635734.
|
Assignee | |
Comment 4•5 years ago
|
||
Here, they are using shared .inc files to import all the things between hiddenWindow and browser.html:
https://searchfox.org/mozilla-central/search?q=%23include+global-scripts.inc&path=
https://searchfox.org/mozilla-central/search?q=include+browser-sets.inc&path=
https://searchfox.org/mozilla-central/search?q=%23include+browser-menubar.inc&path=
https://searchfox.org/mozilla-central/search?q=%23include+browser-doctype.inc&path=
So should we do the same for messenger.xhtml and hiddenWindow.html(which will be renamed to hiddenWindowMac.xhtml)?
|
|
Assignee | |
Comment 5•5 years ago
|
||
Toolbox, keyset and commandset are in such form. We just need to do it for DTD files, Scripts, and Stringbundle.
|
|
Assignee | |
Comment 6•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
|
|
Reporter | |
Comment 7•5 years ago
|
||
|
|
Assignee | |
Comment 8•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/8d4c676d5d53
Update hiddenWindow.xhtml on OSX to hiddenWindowMac.xhtml. r=mkmelin
|
|
Reporter | |
Updated•5 years ago
|
Description
•