Crash in [@ mozilla::layers::ContainerLayerMLGPU::ComputeIntermediateSurfaceBounds]/[@ mozilla::layers::ContainerLayerMLGPU::FindVisibleBounds ]
Categories
(Core :: Graphics: Layers, defect, P3)
Tracking
()
People
(Reporter: marcia, Assigned: jrmuizel)
References
Details
(Keywords: crash, regression)
Crash Data
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
This bug is for crash report bp-fc73c93d-ace9-48fa-b039-6e7d30190623.
Spinning this out of Bug 1506637, since the signature is noticeable on both 69 nightly and the current 70 nightly: https://mzl.la/2MfqIVZ
The first crashes in 69 nightly were in 20190623094201 - based on that a possible regression range might be https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e729bfa4f60157a8e8ed9cd3ae5f9d854ab7f7f3&tochange=a8c21ee98a4c2f683335b8358c11b2fceb863f05
Bug 1557093 is in that range, and I see some code was touched. ni on : nhnt11
(100.0% in signature vs 00.30% overall) address = 0x318
(29.27% in signature vs 00.22% overall) Module "sophos_detoured_x64.dll" = true [100.0% vs 00.61% if platform_version = 10.0.17134]
(90.24% in signature vs 09.05% overall) Module "dcomp.dll" = true [100.0% vs 15.10% if platform_version = 10.0.17134]
(46.34% in signature vs 06.07% overall) CPU Info = family 6 model 42 stepping 7
(70.73% in signature vs 33.27% overall) plugin_name = null
(29.27% in signature vs 66.06% overall) abort_message = null
(76.83% in signature vs 23.75% overall) ipc_channel_error = null [29.27% vs 66.54% if process_type = gpu]
(90.24% in signature vs 61.32% overall) Module "win32u.dll" = true
(19.51% in signature vs 04.08% overall) Addon "firefox@tampermonkey.net" = true
Top 10 frames of crashing thread:
0 xul.dll void mozilla::layers::ContainerLayerMLGPU::ComputeIntermediateSurfaceBounds gfx/layers/mlgpu/ContainerLayerMLGPU.cpp
1 xul.dll static class mozilla::Maybe<mozilla::gfx::IntRectTyped<mozilla::gfx::UnknownUnits> > mozilla::layers::ContainerLayerMLGPU::FindVisibleBounds gfx/layers/mlgpu/ContainerLayerMLGPU.cpp:103
2 xul.dll static class mozilla::Maybe<mozilla::gfx::IntRectTyped<mozilla::gfx::UnknownUnits> > mozilla::layers::ContainerLayerMLGPU::FindVisibleBounds gfx/layers/mlgpu/ContainerLayerMLGPU.cpp:127
3 xul.dll static class mozilla::Maybe<mozilla::gfx::IntRectTyped<mozilla::gfx::UnknownUnits> > mozilla::layers::ContainerLayerMLGPU::FindVisibleBounds gfx/layers/mlgpu/ContainerLayerMLGPU.cpp:127
4 xul.dll void mozilla::layers::ContainerLayerMLGPU::ComputeIntermediateSurfaceBounds gfx/layers/mlgpu/ContainerLayerMLGPU.cpp:157
5 xul.dll bool mozilla::layers::FrameBuilder::Build gfx/layers/mlgpu/FrameBuilder.cpp:69
6 xul.dll void mozilla::layers::LayerManagerMLGPU::RenderLayers gfx/layers/mlgpu/LayerManagerMLGPU.cpp:369
7 xul.dll void mozilla::layers::LayerManagerMLGPU::Composite gfx/layers/mlgpu/LayerManagerMLGPU.cpp:323
8 xul.dll void mozilla::layers::LayerManagerMLGPU::EndTransaction gfx/layers/mlgpu/LayerManagerMLGPU.cpp:278
9 xul.dll void mozilla::layers::CompositorBridgeParent::CompositeToTarget gfx/layers/ipc/CompositorBridgeParent.cpp:1012
Comment 1•5 years ago
|
||
Jeff, it looks like the clipped draw target API changes were in this range, could they have impacted this?
Updated•5 years ago
|
Comment 3•5 years ago
|
||
Clearing needinfo, I took a look and don't really have any knowledge that would be useful here. The change in bug 1557093 was a simple change of what type of click we're handling to open a panel - furthermore, that code has since been replaced.
Reporter | ||
Comment 4•5 years ago
|
||
This is still happening pretty regularly on nightly, with anywhere from 4 - 16 crashes per nightly build. There are no comments and no URLs.
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 5•5 years ago
|
||
I put up a debugging patch here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=efdbc95665dfb76eee6f136561c68ea36abe20c3
Assignee | ||
Comment 6•5 years ago
|
||
This should help us figure what's going on.
Assignee | ||
Updated•5 years ago
|
Comment 8•5 years ago
|
||
bugherder |
Assignee | ||
Comment 9•5 years ago
|
||
I moved the crash to mozilla::layers::ContainerLayerMLGPU::FindVisibleBounds
Assignee | ||
Comment 10•5 years ago
|
||
We're getting a RefLayer instead of a ContainerLayer
Comment 11•5 years ago
|
||
Jeff, do you have more data now that could help solve this crash? The volume on Nightly is still concerning, I would probably take an uplift to beta if it can't be fixed in Nightly. Thanks.
Assignee | ||
Comment 12•5 years ago
|
||
These crashes seem to mostly (97%) be fission related. I don't think this is something we need to worry about in the short term.
Comment 13•5 years ago
|
||
Thanks, marking as fix-optional for 71 then!
Comment 14•5 years ago
|
||
Looks like the crashes are now in bug 1588484.
Comment 15•5 years ago
|
||
This is one of the more common Fission crash signatures, though there were about 80 crashes from only 14 different installations.
Comment 16•5 years ago
|
||
Never mind. I was looking at the wrong query, and it does look like bug 1588484 made this go away for Fission.
Comment 17•5 years ago
|
||
The crashes for this signature are back on Nightly since last week.
Updated•5 years ago
|
Comment 18•5 years ago
|
||
Change the status for beta to have the same as nightly and release.
For more information, please visit auto_nag documentation.
Comment 19•5 years ago
|
||
Crashes are with Fission enabled, marking beta/release as disabled
Updated•5 years ago
|
Comment 20•4 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:jrmuizel, maybe it's time to close this bug?
Assignee | ||
Comment 21•4 years ago
|
||
Sure.
Updated•4 years ago
|
Description
•