Cleanup breadcrumbs.js and breadcrumbs.css after bug 1428917
Categories
(DevTools :: Inspector, defect, P1)
Tracking
(firefox-esr60 unaffected, firefox-esr68 wontfix, firefox68 unaffected, firefox69 wontfix, firefox70 verified)
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox-esr68 | --- | wontfix |
| firefox68 | --- | unaffected |
| firefox69 | --- | wontfix |
| firefox70 | --- | verified |
People
(Reporter: itiel_yn8, Assigned: itiel_yn8)
References
(Regression)
Details
(Keywords: regression, rtl)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
In bug 1428917 I missed that breadcrumbs.js is dependant on RTLness of the browser, and that there are some rules in breadcrumbs.css that are no longer necessary.
This causes the scroll buttons misbehave when clicking (1 click goes to the beginning/end of the whole scrollbar) and double clicking (double clicking does the opposite behavior and scroll the view to the right instead of left and vice versa) them, on RTL only.
This is still better than what was before bug 1428917 was fixed imo.
[Tracking Requested - why for this release]:
Follow up on bug 1428917 (which was already uplifted to beta and ESR), fixing Inspector breadcrumbs behaviour for RTL + cleaning up redundant and now obsolete code.
I already have a working patch for this, but I'm not sure what the timetable for beta and ESR is.
Hopefully I can submit a bug on Sunday.
This will probably need QE testing though as I missed this in bug 1428917.
Another option is to backport bug 1428917 and uplift this if it'll make it in time.
|
||
Comment 4•5 years ago
|
||
We can still take a fix this week.
|
||
Comment 5•5 years ago
|
||
:itiel_yn8, since this bug is a regression, could you fill (if possible) the regressed_by field?
For more information, please visit auto_nag documentation.
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
|
||
Comment 6•5 years ago
|
||
Changing the priority to p1 as the bug is tracked by a release manager for the current beta.
See What Do You Triage for more information
|
|
||
Updated•5 years ago
|
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
Too late for an uplift.
|
|
||
Updated•5 years ago
|
|
|
||
Updated•3 years ago
|
Description
•