Closed Bug 1576316 Opened 5 years ago Closed 5 years ago

Intermittent fission failure: TEST-UNEXPECTED-ERROR | dom/security/test/csp/test_service_worker.html | called finish() multiple times

Categories

(Core :: Privacy: Anti-Tracking, defect, P5)

Product:
Core
Component:
Privacy: Anti-Tracking
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Project Flags:
Fission Milestone M4
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox68 --- unaffected
firefox69 --- unaffected
firefox70 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: ehsan.akhgari)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: intermittent-failure, regression, Whiteboard: [stockwell disable-recommended])

Attachments

(1 file)

Bug 1576316 - Restore a bit of the Fission-incompatible code removed in bug 1575609 in order to satisfy the tests that are relying on it;
(deleted), text/x-phabricator-request
Details
Flags: needinfo?(kmadan)
Regressed by: 1562264
Assignee: nobody → kmadan
Status: NEW → ASSIGNED
Flags: needinfo?(kmadan)

At first glance, it appears that a lot of these don't even call window.open(). I suspect this might have something to do with newly-unskipped Fission tests not cleaning up properly. Probably will just need to update skip-if/fail-if annotations.

Blocks: fission-mochitests
Depends on: 1573633

Just to set proper expectations: I will not be looking at all of the failures listed in comment 0 because it is unclear whether they're all related to bug 1575609. Even for the other failure in the h3 test suite, bug 1573633 is on file. I'm changing the bug summary to clarify the work that will be done here.

Please make sure one bug per failure is on file for each one of the other ones in comment 0 and appropriate folks are needinfo'ed on each one. Thanks!

Summary: Perma mass failure [tier 2] fission tests → Intermittent fission failure: TEST-UNEXPECTED-ERROR | dom/security/test/csp/test_service_worker.html | called finish() multiple times
Assignee: kmadan → nobody
Status: ASSIGNED → NEW

Just for completeness, here are the bugs corresponding to the failures in comment 0:

  1. Bug 1576464
  2. Bug 1576461
  3. Bug 1576456
  4. Bug 1542509 (I guess we'll need a separate perma-Fission bug?)
  5. Same failure as 3.
  6. Bug 1576421

The function called in these tests of course does the wrong thing, but these
tests aren't testing anything related to anti-tracking, so it is probably
harmless to leave this code in until the dependencies described in the comments
in the patch are in place.

No longer depends on: 1573633
Flags: needinfo?(ehsan)
Regressed by: 1575609
No longer regressed by: 1562264
Assignee: nobody → ehsan

(In reply to :kashav from comment #8)

Just for completeness, here are the bugs corresponding to the failures in comment 0:

  1. Bug 1576464
  2. Bug 1576461

Both dupes of this.

  1. Bug 1576456

Unrelated to this.

  1. Bug 1542509 (I guess we'll need a separate perma-Fission bug?)

Unrelated to this (and yes, probably).

  1. Same failure as 3.
  2. Bug 1576421

I think #6 is also a dupe of this one since the test is green on my local tree.

Component: Mochitest → Privacy: Anti-Tracking
Product: Testing → Core
Version: Version 3 → unspecified
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d9790f5a3d0d Restore a bit of the Fission-incompatible code removed in bug 1575609 in order to satisfy the tests that are relying on it; r=baku

https://hg.mozilla.org/mozilla-central/rev/d9790f5a3d0d

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

Failures within this range https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?startday=2019-08-29&endday=2019-09-05&tree=trunk&bug=1576316 are misclassifications.

Whiteboard: [stockwell disable-recommended]

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Fission Milestone: --- → M4
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: