Open Bug 1577879 Opened 5 years ago Updated 2 years ago

FFmpegVideoDecoder incorrectly reports NS_ERROR_OUT_OF_MEMORY when attempting to play certain invalid files such as the track-with-zero-dimensions.mp4 test

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

People

(Reporter: bryce, Unassigned)

Details

If The FfmpegVideoDecoder fails to create an image it will report an out of memory error. This can be misleading, as in the test introduced by bug 1542539 -- in this case the file is malformed (0 by 0 dimensions reported for some frames) and fails validation in CreateAndCopyData. In this scenario we're not running out of memory, but actively aborting our attempt to decode.

It would be useful to differentiate this case and report a different error. This would be helpful for debugging this path, and would make our test logs cleaner. The reason I found this bug is that someone suggested to me that the test could be breaking later tests by causing an OOM -- this turns out not to be the case, but it would be nice to have our tests logs indicate this more clearly.

Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.