Closed
Bug 1585079
Opened 5 years ago
Closed 5 years ago
Fix usage of nsIDocShellTreeItem in Document::GetSameTypeParentDocument
Categories
(Core :: DOM: Navigation, defect, P2)
Core
DOM: Navigation
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | fixed |
People
(Reporter: djvj, Assigned: nika)
References
(Blocks 1 open bug)
Details
(Whiteboard: [rm-docshell-tree-item:hard])
Attachments
(4 files)
Rename this function GetInProcessSameTypeParentDocument, and audit uses. After changes, it should return NULL for out-of-process parents.
Alternatively, this method might need to go away, if making this method unusable for OOP parents makes it nearly worthless for its users.
|
||
Updated•5 years ago
|
Fission Milestone: --- → M5
Priority: -- → P2
|
Reporter | |
Updated•5 years ago
|
Whiteboard: [rm-docshell-tree-item:hard]
|
|
||
Updated•5 years ago
|
Fission Milestone: M5 → Future
|
||
Comment 1•5 years ago
|
||
Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).
Fission Milestone: Future → M6
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → nika
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
|
Assignee | |
Comment 5•5 years ago
|
||
Pushed by nlayzell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ae770c4a16b0
Part 1: Support Document::GetBrowsingContext early during Document lifecycle, r=smaug
https://hg.mozilla.org/integration/autoland/rev/58c51eb6a095
Part 2: Remove GetSameTypeParentDocument from InitReferrerInfo, r=baku
https://hg.mozilla.org/integration/autoland/rev/ba050445b3c9
Part 3: Remove GetSameTypeParentDocument from MaybeStoreUserInteractionAsPermission, r=baku
https://hg.mozilla.org/integration/autoland/rev/c99a28a11899
Part 4: Remove GetSameTypeParentDocument, r=smaug
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ae770c4a16b0
https://hg.mozilla.org/mozilla-central/rev/58c51eb6a095
https://hg.mozilla.org/mozilla-central/rev/ba050445b3c9
https://hg.mozilla.org/mozilla-central/rev/c99a28a11899
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox74:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in
before you can comment on or make changes to this bug.
Description
•