Closed
Bug 1594887
Opened 5 years ago
Closed 5 years ago
Remove xpidl [array] use in nsIMsgFilterPlugin
Categories
(MailNews Core :: Backend, task)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 72.0
People
(Reporter: benc, Assigned: benc)
References
Details
Attachments
(3 files)
|
(deleted),
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → benc
|
|
Assignee | |
Comment 1•5 years ago
|
||
Attachment #9111775 -
Flags: review?(mkmelin+mozilla)
|
|
Assignee | |
Comment 2•5 years ago
|
||
Attachment #9111776 -
Flags: review?(mkmelin+mozilla)
|
|
Assignee | |
Comment 3•5 years ago
|
||
Attachment #9111777 -
Flags: review?(mkmelin+mozilla)
|
|
Assignee | |
Comment 4•5 years ago
|
||
Tedious stuff, but nothing too fancy in there, I think.
Unit tests look clean locally. Try run here:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=2a7fe3a50657cd5971be44626800780902892fee
|
||
Updated•5 years ago
|
Attachment #9111775 -
Flags: review?(mkmelin+mozilla) → review+
|
|
||
Updated•5 years ago
|
Status: NEW → ASSIGNED
|
|
||
Updated•5 years ago
|
Attachment #9111776 -
Flags: review?(mkmelin+mozilla) → review+
|
|
||
Comment 5•5 years ago
|
||
Comment on attachment 9111777 [details] [diff] [review]
1594887-part-3-nsIJunkMailPlugin-1.patch
Review of attachment 9111777 [details] [diff] [review]:
-----------------------------------------------------------------
::: mailnews/base/util/nsMsgDBFolder.cpp
@@ +2135,5 @@
> nsTArray<uint32_t> antiIndices;
> rv = traitService->GetEnabledAntiIndices(antiIndices);
> NS_ENSURE_SUCCESS(rv, rv);
>
> + rv = aJunkMailPlugin->ClassifyTraitsInMessage(nsDependentCString(aURI),
I was going to ask if you're sure aURI isn't null. But it looks like this whole method (SpamFilterClassifyMessage) is dead code and should just be removed
Attachment #9111777 -
Flags: review?(mkmelin+mozilla) → review+
|
|
Assignee | |
Updated•5 years ago
|
Keywords: checkin-needed-tb
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/d361ca43bf11
Remove xpidl [array] use in nsIMsgTraitClassificationListener. r=mkmelin
https://hg.mozilla.org/comm-central/rev/86c11d411a01
Remove xpidl [array] use in nsIMsgTraitDetailListener. r=mkmelin
https://hg.mozilla.org/comm-central/rev/30ad6ed6ebb6
Remove xpidl [array] use in nsIJunkMailPlugin. r=mkmelin DONTBUILD
|
||
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 72.0
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/f2927c0ca076
Follow-up: Reformat. rs=reformat
You need to log in
before you can comment on or make changes to this bug.
Description
•