Closed Bug 1594892 Opened 5 years ago Closed 5 years ago

Remove xpidl [array] use in nsIMsgDatabase

Categories

(MailNews Core :: Backend, task)

Product:
MailNews Core
Component:
Backend
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 73.0

People

(Reporter: benc, Assigned: benc)

References

Details

Attachments

(5 files, 1 obsolete file)

1594892-part1-nsIMsgDatabase.MarkThreadRead-2.patch
(deleted), patch
mkmelin
: review+
Details | Diff | Splinter Review
1594892-part2-nsIMsgDatabase.MarkAllRead-1.patch
(deleted), patch
mkmelin
: review+
Details | Diff | Splinter Review
1594892-part3-nsIMsgDatabase.deleteMessages-1.patch
(deleted), patch
mkmelin
: review+
Details | Diff | Splinter Review
1594892-part4-nsIMsgDatabase.getNewList-1.patch
(deleted), patch
mkmelin
: review+
Details | Diff | Splinter Review
1594892-part5-nsIMsgDatabase.refreshCache-1.patch
(deleted), patch
mkmelin
: review+
Details | Diff | Splinter Review
No description provided.
Assignee: nobody → benc
No longer blocks: 1562158
Blocks: 1551704
Depends on: 1604645

nsIDatabase is biggie, so breaking it up by method.

Attachment #9116804 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9116804 [details] [diff] [review] 1594892-part1-nsIMsgDatabase.MarkThreadRead-1.patch (doh - sorry... some chunks seem to have slipped out into another changeset. Will upload a new one.)
Attachment #9116804 - Flags: review?(mkmelin+mozilla)
Attachment #9116804 - Attachment is obsolete: true
Attachment #9116861 - Flags: review?(mkmelin+mozilla)
Attachment #9116862 - Flags: review?(mkmelin+mozilla)
Attachment #9116864 - Flags: review?(mkmelin+mozilla)
Attachment #9116875 - Flags: review?(mkmelin+mozilla)

Last one, I think. I'll do a try run on the whole lot if I can find a short window of non-bustage :-)

Attachment #9116882 - Flags: review?(mkmelin+mozilla)
Attachment #9116861 - Flags: review?(mkmelin+mozilla) → review+
Comment on attachment 9116862 [details] [diff] [review] 1594892-part2-nsIMsgDatabase.MarkAllRead-1.patch Review of attachment 9116862 [details] [diff] [review]: ----------------------------------------------------------------- ::: mailnews/db/msgdb/public/nsIMsgDatabase.idl @@ +414,5 @@ > boolean IsMarked(in nsMsgKey key); > /// Does the message have attachments. > boolean HasAttachments(in nsMsgKey key); > > + Array<nsMsgKey> MarkAllRead(); While we're changing, let's make it properly lower cased markAllRead. (Since all callers are cpp, no other changed needed.)
Attachment #9116862 - Flags: review?(mkmelin+mozilla) → review+
Attachment #9116864 - Flags: review?(mkmelin+mozilla) → review+
Attachment #9116875 - Flags: review?(mkmelin+mozilla) → review+
Attachment #9116882 - Flags: review?(mkmelin+mozilla) → review+
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird 73.0

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/867262f56df2
xpidl [array] removal from nsIMsgDatabase.MarkThreadRead(). r=mkmelin
https://hg.mozilla.org/comm-central/rev/f6484bfeb6af
xpidl [array] removal from nsIMsgDatabase.MarkAllRead(). r=mkmelin
https://hg.mozilla.org/comm-central/rev/8f61543e6276
xpidl [array] removal from nsIMsgDatabase.deleteMessages(). r=mkmelin
https://hg.mozilla.org/comm-central/rev/fb1646d8e45c
'Bug 1594892 - xpidl [array] removal from nsIMsgDatabase.getNewList(). r=mkmelin
https://hg.mozilla.org/comm-central/rev/e68e4b9259f3
xpidl [array] removal from nsIMsgDatabase.refreshCache(). r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/1be1e6dac386 Follow-up: Reformat. rs=reformat DONTBUILD

Formatting patches before they land would be great, and also checking commit messages :-(

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: