Closed
Bug 1594901
Opened 5 years ago
Closed 5 years ago
Remove xpidl [array] use in nsIPop3IncomingServer
Categories
(MailNews Core :: Backend, task)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 73.0
People
(Reporter: benc, Assigned: benc)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → benc
|
|
Assignee | |
Comment 1•5 years ago
|
||
Mostly straightforward, although there are a few non-interface nsCOMArray => nsTArray conversions to avoid using temporary arrays.
Also, I reversed a list in nsPop3GetMailChainer::GetNewMailForServers() so it could be processed by repeatedly popping the last element out rather than pooping the first and shifting the array forward each time.
Attachment #9114461 -
Flags: review?(mkmelin+mozilla)
|
||
Comment 2•5 years ago
|
||
Comment on attachment 9114461 [details] [diff] [review]
1594901-remove-xpidl-array-in-nsIPop3IncomingServer-1.patch
Review of attachment 9114461 [details] [diff] [review]:
-----------------------------------------------------------------
Looks ok to me. r=mkmelin
Is there a try run?
Attachment #9114461 -
Flags: review?(mkmelin+mozilla) → review+
|
|
||
Updated•5 years ago
|
Status: NEW → ASSIGNED
|
|
||
Comment 3•5 years ago
|
||
|
|
||
Updated•5 years ago
|
Keywords: checkin-needed-tb
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/5ce0c098f6c4
Remove xpidl [array] use in nsIPop3IncomingServer. r=mkmelin
|
|
||
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 73.0
You need to log in
before you can comment on or make changes to this bug.
Description
•